New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grid.locale-sq.js overrides localization for English #882

Closed
jimitndiaye opened this Issue Sep 6, 2017 · 9 comments

Comments

Projects
None yet
2 participants
@jimitndiaye

jimitndiaye commented Sep 6, 2017

$.jgrid.regional["en"] = {
	defaults : {
		recordtext: "Shfaq {0} - {1}/{2}",
		emptyrecords: "Nuk ka rreshta për të shfaqur",
		loadtext: "Duke u ngarkuar...",
...

As you can see it uses en as its language key, overriding the default English translations. As a result the translations get overridden.

@tonytomov

This comment has been minimized.

Show comment
Hide comment
@tonytomov

tonytomov Sep 6, 2017

Owner

Hello,

I'm not sure what is the problem. If you overwrite any language translations into lang file they will be used into the grid. For me it is not a problem. Sorry to say this, but I'm unable to understand the problem.

Maybe some example code will clear this

Owner

tonytomov commented Sep 6, 2017

Hello,

I'm not sure what is the problem. If you overwrite any language translations into lang file they will be used into the grid. For me it is not a problem. Sorry to say this, but I'm unable to understand the problem.

Maybe some example code will clear this

@jimitndiaye

This comment has been minimized.

Show comment
Hide comment
@jimitndiaye

jimitndiaye Sep 6, 2017

If you check all the other language files they have something similar to:
$.jgrid.regional["<lang>"] where lang is their corresponding language code (and thus unique). This file instead of using sq uses en so it overrides the original English translation (which, correctly, uses en).

Due to this when you use $.jgrid.setRegional(gridId, { regional: "en" }), instead of getting English you get Albanian.

This file should be fixed to say $.jgrid.regional["sq"] = { ...

To see the problem edit this demo to include the grid.locale-sq.js file then try to set the language to English - you will get Albanian instead.

jimitndiaye commented Sep 6, 2017

If you check all the other language files they have something similar to:
$.jgrid.regional["<lang>"] where lang is their corresponding language code (and thus unique). This file instead of using sq uses en so it overrides the original English translation (which, correctly, uses en).

Due to this when you use $.jgrid.setRegional(gridId, { regional: "en" }), instead of getting English you get Albanian.

This file should be fixed to say $.jgrid.regional["sq"] = { ...

To see the problem edit this demo to include the grid.locale-sq.js file then try to set the language to English - you will get Albanian instead.

@tonytomov

This comment has been minimized.

Show comment
Hide comment
@tonytomov

tonytomov Sep 6, 2017

Owner

If you do

$.jgrid.regional["en"] = {
	defaults : {
		recordtext: "Shfaq {0} - {1}/{2}",
...

you overwrite the texts in the language en file.

it is the same if you have initially set

var somevaraible['en'] = 1;

and then after set this you do

somevaraible['en'] = 2;

of course after calling

console.log(somevaraible['en'])

it will give you 2.

What you do is equivalent to set these texts after the lang file.

With other words it can be dynamically changed.

Owner

tonytomov commented Sep 6, 2017

If you do

$.jgrid.regional["en"] = {
	defaults : {
		recordtext: "Shfaq {0} - {1}/{2}",
...

you overwrite the texts in the language en file.

it is the same if you have initially set

var somevaraible['en'] = 1;

and then after set this you do

somevaraible['en'] = 2;

of course after calling

console.log(somevaraible['en'])

it will give you 2.

What you do is equivalent to set these texts after the lang file.

With other words it can be dynamically changed.

@tonytomov tonytomov closed this Sep 6, 2017

@jimitndiaye

This comment has been minimized.

Show comment
Hide comment
@jimitndiaye

jimitndiaye Sep 6, 2017

It is literally two letters that are incorrect as compared to every other language file. It is a bug. Your own demo app which I linked above shows you the bug. Quite frankly closing the issue without attempting to understand a legitimate bug seriously dampens our resolve to obtain a commercial license for this product if this is the kind of support we can expect.

Our scenario is identical to your localization demo here: http://www.guriddo.net/demo/guriddojs/functionality/localization/index.html

All we do is load up all the grid.locale-*.js files we need then dynamically switch between locales as needed. But because of this one file it doesn't work, which is why I suggested you add this file to your demo so you can see the problem.

jimitndiaye commented Sep 6, 2017

It is literally two letters that are incorrect as compared to every other language file. It is a bug. Your own demo app which I linked above shows you the bug. Quite frankly closing the issue without attempting to understand a legitimate bug seriously dampens our resolve to obtain a commercial license for this product if this is the kind of support we can expect.

Our scenario is identical to your localization demo here: http://www.guriddo.net/demo/guriddojs/functionality/localization/index.html

All we do is load up all the grid.locale-*.js files we need then dynamically switch between locales as needed. But because of this one file it doesn't work, which is why I suggested you add this file to your demo so you can see the problem.

@tonytomov

This comment has been minimized.

Show comment
Hide comment
@tonytomov

tonytomov Sep 6, 2017

Owner

Sorry to close the issue, but you have added(updated) the demo and description of this after my comment. It is better always to provide a demo which demonstrates the problem.

When a bug is reported it should be pointed with proofs as you do after closing.

Will check this and replay ASAP.

Owner

tonytomov commented Sep 6, 2017

Sorry to close the issue, but you have added(updated) the demo and description of this after my comment. It is better always to provide a demo which demonstrates the problem.

When a bug is reported it should be pointed with proofs as you do after closing.

Will check this and replay ASAP.

@tonytomov

This comment has been minimized.

Show comment
Hide comment
@tonytomov

tonytomov Sep 6, 2017

Owner

I have see the problem. It is fixed b09edc8 . Sorry that I do not understand it.
Kind Regards

Owner

tonytomov commented Sep 6, 2017

I have see the problem. It is fixed b09edc8 . Sorry that I do not understand it.
Kind Regards

@jimitndiaye

This comment has been minimized.

Show comment
Hide comment
@jimitndiaye

jimitndiaye commented Sep 6, 2017

@tonytomov tonytomov added the Bug label Sep 6, 2017

@tonytomov tonytomov closed this Sep 6, 2017

@tonytomov

This comment has been minimized.

Show comment
Hide comment
@tonytomov

tonytomov Sep 11, 2017

Owner

Hello,

If the problem is fixed, could you please close the issue.

Thank you.

Owner

tonytomov commented Sep 11, 2017

Hello,

If the problem is fixed, could you please close the issue.

Thank you.

@jimitndiaye

This comment has been minimized.

Show comment
Hide comment
@jimitndiaye

jimitndiaye Sep 11, 2017

It seems to already be closed

jimitndiaye commented Sep 11, 2017

It seems to already be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment