fix performance problem of TreeGrid during expanging or collapsing of nodes having large number of children #278

Closed
wants to merge 1 commit into from

1 participant

@OlegKi

Hello Tony,

I described the problem in the bug fix. In the suggested code I improved my original suggestion by usage of $($t.rows.namedItem(id)) instead of previously suggested $("#"+$.jgrid.jqID(id)). The current jqGrid code uses $("#"+$.jgrid.jqID(id),$t.grid.bDiv) which is very slow because no index can be used for the searching.

The demo demonstrate the working of the fixed version which is much better as the demo which uses jqGrid 4.3.1.

Best regards
Oleg

Signed-off-by: Dr. Oleg Kiriljuk oleg.kiriljuk@ok-soft-gmbh.com

@OlegKi OlegKi fix performance problem with expanging or collapsing nodes having lar…
…ge number of children.

Signed-off-by: Dr. Oleg Kiriljuk <oleg.kiriljuk@ok-soft-gmbh.com>
8927668
@OlegKi OlegKi closed this Mar 26, 2012
@pro85 pro85 pushed a commit to pro85/jqGrid that referenced this pull request Mar 17, 2014
@OlegKi OlegKi Fixing the performance problem of TreeGrid during expanging or collap…
…sing of nodes having large number of children

(copy of [the previous pull request](tonytomov#278))

Hello Tony,

I described the problem in [the bug fix](http://www.trirand.com/blog/?page_id=393/bugs/slow-performance-of-treegrid-on-collapse-or-expand/#p26091). In the suggested code I improved my original suggestion by usage of `$($t.rows.namedItem(id))` instead of previously suggested `$("#"+$.jgrid.jqID(id))`. The current jqGrid code uses `$("#"+$.jgrid.jqID(id),$t.grid.bDiv)` which is very slow because no index can be used for the searching.

[The demo](http://www.ok-soft-gmbh.com/jqGrid/TreeGrid2.html) demonstrate the working of the fixed version which is much better as [the demo](http://www.ok-soft-gmbh.com/jqGrid/treegrid0.html) which uses jqGrid 4.3.1.

Best regards
Oleg

Signed-off-by: Dr. Oleg Kiriljuk <oleg.kiriljuk@ok-soft-gmbh.com>
752c430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment