Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fixed search filters addition/deletion #375

Merged
merged 2 commits into from

2 participants

@rohitggarg

Issue
1. Select not null/is null from filter
2. Try adding another filter.
3. Notice the fields against not null/is null filter are not readonly anymore.

This fix maintains the readonly state for search ops involving null.

rohitggarg added some commits
@rohitggarg rohitggarg Fixed search filters addition/deletion
Issue
1. Select not null/is null from filter
2. Try adding another filter.
3. Notice the fields against not null/is null filter are not readonly anymore.

This fix maintains the readonly state for search ops involving null.
2979caa
@rohitggarg rohitggarg fixed for chrome 77b67c8
@tonytomov tonytomov merged commit bbc4db7 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 22, 2012
  1. @rohitggarg

    Fixed search filters addition/deletion

    rohitggarg authored
    Issue
    1. Select not null/is null from filter
    2. Try adding another filter.
    3. Notice the fields against not null/is null filter are not readonly anymore.
    
    This fix maintains the readonly state for search ops involving null.
  2. @rohitggarg

    fixed for chrome

    rohitggarg authored
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 1 deletion.
  1. +4 −1 js/grid.filter.js
View
5 js/grid.filter.js
@@ -453,7 +453,10 @@ $.fn.jqFilter = function( arg ) {
}
}
var ruleDataInput = $.jgrid.createEl(cm.inputtype,cm.searchoptions, rule.data, true, that.p.ajaxSelectOptions, true);
-
+ if(rule.op == 'nu' || rule.op == 'nn') {
+ $(ruleDataInput).attr('readonly','true');
+ $(ruleDataInput).attr('disabled','true');
+ } //retain the state of disabled text fields in case of null ops
// dropdown for: choosing operator
var ruleOperatorSelect = $("<select class='selectopts'></select>");
ruleOperatorTd.append(ruleOperatorSelect);
Something went wrong with that request. Please try again.