Summary: Quick code cleaning - Facebook class doesn't need to inherit from FBRequestDelegate. Test Plan: Check if it compiles and login in / login out works. Reviewers: yariv Reviewed By: yariv CC: jgabbard, yariv Differential Revision: 380359
Summary: Whenever we call an API that returns a "session expired" error we should clear the session data (acessToken / expiring date) and notify user about it. Test Plan: Login to app, then log out using www, then try calling rest / graph method. Reviewers: yariv, jimbru, brent, toddkrabach, jonathan Reviewed By: yariv CC: lshepard, yariv, kamil, brent, jonathan, toddkrabach Differential Revision: 378197
Summary: Current SDK doesn't support multiple requests at the same time. To change this I added a new container to the Facebook class that stores all the requests. Whenever the request finishes it's work (by loading the response or by returning an error) we remove it from the container. Since FBRequests are autorelased they will be deleted at the end of the event loop. Test Plan: Check if the app works + tried to call the GetMe API method twice. Reviewers: yariv, toddkrabach, jonathan Reviewed By: toddkrabach CC: yariv, toddkrabach, jonathan, jimbru, lshepard, jgabbard, kamil Differential Revision: 378930
Summary: Current Hackbook example implements two FBSessionDelegates. Switching between them requires modifying the internals of Facebook class and is very confusing. The solution is to remove FBSessionDelegate implementation from APICallsViewController, and modify the code in a way that will work with only one sessionDelegate. Test Plan: Try the following (two times every plan :) ): - login, execute any method, logout - login, execute any method, uninstall app - login, cancel login, login, execute any method, logout - login, request additional perms, cancel, request additional perms, grant, logout Reviewers: yariv Reviewed By: yariv CC: jimbru, lshepard, kamil, yariv Differential Revision: 377641
Summary: Use UITableViewCellSelectionStyleNone instead of UITableViewCellEditingStyleNone for selectionStyle. Test Plan: On iOS simulator 5.0 test Hackbook iOS sample app, publish feed, graph api sections. Reviewers: brent Reviewed By: brent CC: lshepard, yariv, brent Differential Revision: 365804 Revert Plan: OK
Summary: Part of the discussion of the abandoned diff https://phabricator.fb.com/D342789 was that we should update the Hackbook iOS sample app to show developers how to process data passed back from the dialog. Changes were made to use dialogCompleteWithUrl: instead of dialogDidComplete: method. Other tweaks made to display a success message back to the user when an app request was sent. Also NSLog the post_id and request_ids information so developer can check these out. Changes still need to be made to the iOS SDK docs (https://developers.facebook.com/docs/reference/iossdk/FBDialogDelegate/) to let developers know how to handle the dialog data in the callback. Test Plan: 1/ On iOS simulator 4.3 ran through the Publish Feed and Send Request flows. Checked it works and shows the proper user messages and debug messages (that developers could use in the future). 2/ Tested on iPhone 5.0 and tested feed and app request dialog flows. Reviewers: brent Reviewed By: brent CC: lshepard, yariv, brent, caabernathy Differential Revision: 360490 Revert Plan: OK Task ID: 697899
Summary: Related to pull requests facebook#405 facebook#407 Test Plan: 1/ Tested Hackbook iOS app with iPhone 4 device with iOS 5, ran through various screens and tested dialog. 2/ Tested Hackbook iOS app with iPad 2 device with iOS 4.3, ran through various screens and tested dialog. Reviewers: yariv, brent Reviewed By: yariv CC: lshepard, yariv Differential Revision: 355088 Revert Plan: OK Task ID: 786690
Summary: Pulled from facebook#401 Test Plan: 1/ Ran on iPhone 4 device with iOS 5, Hackbook iOS app, launched feed dialog, rotate all orientations and check works as expected. Also rotated device before launching dialog and rotating dialog to see it performed well. 2/ Ran experiment (1) with iPhone 4.3 simulator. 3/ Ran experiment (1) with iPad 4.3 simulator. 4/ Ran experiment (1) with iPad 5.0 simulator. Reviewers: yariv, brent Reviewed By: yariv CC: lshepard, yariv Differential Revision: 354600 Revert Plan: OK Task ID: 673148
…eak fix, need to release before making savedAPIResult nil first.
…in UITableViewCell selectionStyle assignment
Summary: Moving the url scheme suffix parameter from authorize: to init:, where it fits better, as it behaves in a similar way to appId. Test Plan: Modified the demo app to use the new method signatures. Verified SSO still worked with and without a url scheme suffix. Reviewers: lshepard, brent, caabernathy, teck Reviewed By: brent CC: brent Differential Revision: 335813
Summary: urlSchemeSuffix is more descriptive and easier to grok than localAppId. Warning: This changes breaks compatibility with the previous version of the SDK. Please update your code to use the latest method signature. Test Plan: compiled and ran the demo app with a urlSchemeSuffix configured Reviewers: brent, lshepard, teck Reviewed By: lshepard CC: brent, lshepard Differential Revision: 334704 Task ID: 737701
…allback to the inline authentication dialog in -[Facebook handleOpenURL:]
Summary: The expireSession call was put in as a precaution to make sure that apps sessions were really no longer good. However, this is unnecessary and it causes issues with apps that were expecting the session to remain usable even after the user logged out. So let's remove this call and leave it up to the app developer to expire the session if they want. Test Plan: Logged in and out of the demo app. Reviewed By: trvish
…gate changes. Add notice on issue reporting.
Summary: The change basically just sets the session delegate in the constructor so it's available when handleOpenUrl is called. Test Plan: Ran the DemoApp and ensured SSO still works. Reviewed By: toddkrabach Reviewers: seshadri, leon, atishm, toddkrabach, lshepard, caabernathy Differential Revision: 297414 Task ID: 653835
Summary: Edited uploadPhoto to use requestWithGraphPath instead of the legacy REST api requestWithMethodName method. Also added the publish_stream permission, which is needed for uploading photos. Test Plan: Run the DemoApp and login. Click the upload button and verify that a photo was uploaded to the user's Facebook account (pending approval). Reviewed By: yariv Reviewers: yariv CC: yariv Differential Revision: 257551
Summary: This is the SDK diff to support the local_client_id URL parameter that we added to the FB app. I named it 'localAppId' to be consistent with the 'appId' parameter to the same function. Test Plan: bound the demo app to 'fb1234foo' and passed 'foo' as the localAppId value. verified the SDK used the 'fbauth2' url scheme to open the fb app and that the fb app successfully redirected back to the demo app. Reviewed By: brent Reviewers: lshepard, atishm, brent, oyamauchi, jimbru CC: brent Differential Revision: 211201
Updated the dialog() method to always include app_id. This will prevent an error if a dialog is requested and the application doesn't have an access token. App_id must now be specified in the Facebook constructor as this saves specifying it with every request. Xcode project has been updated to build with iOS SDK 4.3.