Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review HTML/CSS/LESS #9

Open
toolness opened this issue Feb 26, 2015 · 1 comment
Open

Code review HTML/CSS/LESS #9

toolness opened this issue Feb 26, 2015 · 1 comment

Comments

@toolness
Copy link
Owner

I don't consider myself an HTML, CSS, or LESS expert, so I'd appreciate some code review (or I can rubber duck w/ someone). In particular:

  • I'm using LESS, but I'm not actually building Bootstrap from LESS; just importing its variables.less to reuse some of its variables. Not sure if that is cool or not.
  • Not sure how well my CSS rules follow best practices. For instance, I'm using > in a number of my rules, which could break as HTML changes--might be better to come up with explicit classes for such things.
  • Cassie's original mockups used a 16-column grid, while Bootstrap uses a 12-column grid. My code attempts to resolve this by nesting columns, which I'm not sure is the best approach.
  • I'm using CSS flex layout a lot but I'm not sure how smart that is; I guess it depends on what our criteria for browser compatibility is, and how bad the site looks on browsers without flex support. According to caniuse it appears IE9 doesn't support flex layout at all, while IE10 only partially supports it. Also not sure about the stock Android browser on older versions of Android.
  • I suspect I'm not using the most semantically-relevant HTML tags that I could be using, so that could use some review.
  • I doubt my HTML works very well on screen-readers, so I should probably check that. And run the HTML through a validator, perhaps.
@simonwex
Copy link

simonwex commented Mar 4, 2015

This issue was moved to mozilla/learning.mozilla.org#119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants