New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

godep save missing some dependencies #486

Open
setekhid opened this Issue Jun 3, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@setekhid

setekhid commented Jun 3, 2016

See here https://github.com/setekhid/godeps-bug

I expected godep save all dependencies recursively in Godeps folder when I run godep save ./....

But I got some packages missing, suck like github.com/setekhid/godeps-debug in Godeps.json file, but the folder is empty in _workspace.

godep version output

godep v74 (darwin/amd64/go1.4.2)

go version output

go version go1.4.2 darwin/amd64

@freeformz

This comment has been minimized.

Contributor

freeformz commented Jun 3, 2016

This works for me.

$ go get github.com/setekhid/godeps-bug
$ cd $GOPATH/go/src/github.com/setekhid/godeps-bug
$ rm -rf Godeps              # remove any old Godep data
$ godep save
$ find Godeps
Godeps
Godeps/_workspace
Godeps/_workspace/.gitignore
Godeps/_workspace/src
Godeps/_workspace/src/github.com
Godeps/_workspace/src/github.com/setekhid
Godeps/_workspace/src/github.com/setekhid/godeps-debug
Godeps/_workspace/src/github.com/setekhid/godeps-debug/ignored.go
Godeps/_workspace/src/github.com/setekhid/godeps-debug/subpkt
Godeps/_workspace/src/github.com/setekhid/godeps-debug/subpkt/struct.go
Godeps/Godeps.json
Godeps/Readme

Note that ignored.go is included.

PS: Workspace support is deprecated.

I tried this with my godep compiled with 1.7beta1 and 1.4.2 and the results are the same.

If you can reproduce please run save with -d -v, capture all of the output and upload it somewhere so that I can inspect it.

Thanks!

@setekhid

This comment has been minimized.

setekhid commented Jun 6, 2016

Thanks for the guild above, I've figured out the reason.

Well, I'd like to collect every my own projects into a special path, and link these repo's root directories into $GOPATH. That cause some trouble while godep iterating the dependencies. kr/fs.Walk will not trace symbolic links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment