New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

以 number 當 stock key 似乎不妥 #9

Closed
dlintw opened this Issue Jan 9, 2014 · 4 comments

Comments

Projects
None yet
2 participants
@dlintw

dlintw commented Jan 9, 2014

臺灣股票應該會有含英文字母. 建議改以文字當 key,
eg.
03236C 元牛Y1

@dlintw

This comment has been minimized.

Show comment
Hide comment
@dlintw

dlintw Jan 9, 2014

另外一個例子是 s = Stock(0050) 應該會失敗.

dlintw commented Jan 9, 2014

另外一個例子是 s = Stock(0050) 應該會失敗.

@toomore

This comment has been minimized.

Show comment
Hide comment
@toomore

toomore Jan 10, 2014

Owner

好,我修正一下

Owner

toomore commented Jan 10, 2014

好,我修正一下

toomore added a commit that referenced this issue Jan 10, 2014

toomore added a commit that referenced this issue Jan 10, 2014

toomore added a commit that referenced this issue Jan 10, 2014

toomore added a commit that referenced this issue Jan 10, 2014

@toomore

This comment has been minimized.

Show comment
Hide comment
@toomore

toomore Jan 10, 2014

Owner

@dlintw 已修正到 v0.4.2,感謝建議!

Owner

toomore commented Jan 10, 2014

@dlintw 已修正到 v0.4.2,感謝建議!

@toomore toomore closed this Jan 10, 2014

@dlintw

This comment has been minimized.

Show comment
Hide comment
@dlintw

dlintw Jan 11, 2014

It works.

dlintw commented Jan 11, 2014

It works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment