New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internationalization #22
Conversation
sorry for the indentation |
This reverts commit 8597816.
@toopay Sorry, I do not think I could change the pull after validation. I will work on a different branch next time. |
@bierdok Thanks. If you want to add some feature, focus on that. |
Any plan to merge this ? |
@bierdok are you done? |
@toopay Yes you could! If you are on master, here the process to update your pull-request, rebased on master: $ git add toopay https://github.com/toopay/bootstrap-markdown.git
$ git fetch fetch toopay
$ git rebase -i toopay/master
# Do what you need (delete the 2 less review commit)
$ git push -f You're github master branch will be overwritten and the pull request will be updated. But you are right: when you plan to submit a pull request, always work in a branch with an explicit name. |
+1 for this feature ! |
I'll close this. Lets disscuss furthermore at #46 |
add internationalization support and french translation
how to