Add missing binarySlice/binaryWrite methods #9

Merged
merged 1 commit into from Feb 27, 2013

Conversation

Projects
None yet
2 participants
Contributor

tonistiigi commented Feb 27, 2013

binarySlice() and binaryWrite() are referenced from the code but such methods don't exist. Seems that current ascii implementation is actually same that node uses for binary.

I didn't change the ascii behavior but it's not quite the same that node uses(see commented in testcase).

Owner

toots commented Feb 27, 2013

Thanks!

@toots toots added a commit that referenced this pull request Feb 27, 2013

@toots toots Merge pull request #9 from tonistiigi/binary-encoding
Add missing binarySlice/binaryWrite methods
d0c8c93

@toots toots merged commit d0c8c93 into toots:master Feb 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment