Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveRecord::RecordInvalid: Validation failed: Visibility is reserved #10409

Closed
yingziwu opened this issue Mar 28, 2019 · 12 comments

Comments

Projects
None yet
5 participants
@yingziwu
Copy link

commented Mar 28, 2019

Expected behaviour

No error.

Actual behaviour

After upgrade to master version (24d5b6f), I got error ActiveRecord::RecordInvalid: Validation failed: Visibility is reserved.

image

image

After disable relays, I try to retry failed tasks and got no error.
But if relays are enabled, retry failed tasks is no use.

log file:
mastodon_relay.log.zip

relay list:

Steps to reproduce the problem

Enable relays.

Specifications

Mastodon 2.7.4 24d5b6f9e39d2ac62a9657c7d19bc8c437b0735b
Ruby 2.6.1p33
PostgreSQL 9.6.11
Redis 3.2.6
@yingziwu

This comment has been minimized.

Copy link
Author

commented Mar 28, 2019

@IzaliaMae
I also meet this problem.

@ThibG

This comment has been minimized.

Copy link
Collaborator

commented Mar 29, 2019

This is, arguably, a bug in the relay software, which sends the Announce to an undefined collection.
I don't think there's much we can or should do here, except avoid retrying jobs that trigger validation errors.

@kaniini

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

What do you mean 'undefined collection'? Do I need to actually return JSON-LD there or something?

@ThibG

This comment has been minimized.

Copy link
Collaborator

commented Mar 29, 2019

@kaniini

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

Ah, yeah. I merged the change.

@IzaliaMae

This comment has been minimized.

Copy link

commented Mar 29, 2019

Looks like this fixed the issue. Thanks :3

@yingziwu

This comment has been minimized.

Copy link
Author

commented Mar 29, 2019

Thanks :3

@yingziwu yingziwu closed this Mar 29, 2019

@ashfurrow

This comment has been minimized.

Copy link
Collaborator

commented May 2, 2019

I'm seeing this on Mastodon 2.8.0, but only from https://relay.selfhosting.rocks. Could this be an error on their end? Anyone else seeing this?

@ThibG

This comment has been minimized.

Copy link
Collaborator

commented May 2, 2019

@ashfurrow

This comment has been minimized.

Copy link
Collaborator

commented May 2, 2019

Ah, interesting. So I shouldn't be seeing retries on these jobs at all? I am seeing them retried. Any extra data I can provide here?

Which PR are you referring to? I don't see any listed in GitHub.

@ThibG

This comment has been minimized.

Copy link
Collaborator

commented May 2, 2019

@ashfurrow

This comment has been minimized.

Copy link
Collaborator

commented May 2, 2019

Got it. Thank you 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.