Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Pinned hashtag feature does not work anymore with multiple hashtags #12453

Open
GerryT11 opened this issue Nov 23, 2019 · 7 comments
Open

Comments

@GerryT11
Copy link

@GerryT11 GerryT11 commented Nov 23, 2019

Bug description

The feature to pin hashtags and to include additional tags for this column worked nicely until some weeks ago, but then I noticed a severe regression of this feature. Since then, the frequency of new messages in the columns with multiple tags has substantially dropped. The regression is that the pinned hashtag search does not search additional tags correctly and omits a substantial number of toots.

Expected behaviour

The pinned hashtag feature should show all toots that match any of the hashtags in the list.

Actual behaviour

The pinned hashtag feature does not work anymore with multiple hashtags. It does not display all relevant toots.

Steps to reproduce the problem

Here an example (see screenshot Mastodon-BugReport-PinnedSearches2:

  • I have a column searching and displaying multiple hashtags related to "climate change", including the hashtag "klimawandel". The last toot is from 14 hours ago. You see it in the left column of the screenshot.
  • In the right column of the screenshot, I just just searched the hashtag "klimawandel" and there were several toots much newer than in the pinned search. E.g. 13min, 4h, ....

Specifications

Since when: Since a Mastodon update some weeks ago. Before, it worked correctly. The bug is still present in v3.0.1
Reproducibility: Always. I noticed the bug in several pinned hashtag columns on mastodon.social and bonn.social

@Gargron

This comment has been minimized.

Copy link
Member

@Gargron Gargron commented Nov 23, 2019

You can combine at most 4 hashtags per mode (any/all/none) since v3.0.1 for performance reasons.

@GerryT11

This comment has been minimized.

Copy link
Author

@GerryT11 GerryT11 commented Nov 23, 2019

Thanks @Gargron for your quick answer.

It's unfortunate that it was necessary to limit it to 4 search tags due to performance. It would be great to have more than 4 hashtags in the column. At the moment, I have over 20 tags (which doesn't work anymore, of course).

Thus, 2 questions to you:
//1: Will it be possible in future releases to increase the current limit of 4 search tags?

//2: In the web interface, the feature is described as "Include additional tags for this column", which is a bit misleading. Wouldn't it be better for now to change the wording to e.g. "Add max. 3 more tags for this column"?

@Cassolotl

This comment has been minimized.

Copy link

@Cassolotl Cassolotl commented Nov 24, 2019

This is maybe where option to follow hashtags #1096 would come in handy. It's the second most 👍ed issue on the open issue list. I have nine pinned hashtag search columns, all with more than one hashtag being monitored, because on a small instance I want to be able to see and boost things relevant to my interests and the federated timeline doesn't meet that need. I would much rather follow the hashtags and have them appear in my Home column because they take up so much space.*

What's more, I had no idea that pinned hashtag search columns were limited to four hashtags - there was no indication in the UI that anything beyond the first four were ignored. So I've opened No indication in web UI that hashtag search pinned columns only work for the first four hashtags #12458!


* Support groups #139 doesn't meet my needs, because:

when I used !groups on GNU Social, my main feeling was that they were pretty confusing. It required someone to set it up, and there could be three groups with the same name on three different instances all with different rules about who can join. If an admin made a group where members (followers and posters) had to be approved, and then the admin became inactive, the group just became stagnant forever.

So it seemed to me like following a hashtag might be better, because there were no leaders and anyone could keep joining in without having to wait for permission.

@GerryT11

This comment has been minimized.

Copy link
Author

@GerryT11 GerryT11 commented Nov 24, 2019

I close this bug, because the pinned hashtag feature works as intended (Gargron pointed it out).

However, there are two follow-up bugs:
#12458 to indicate to the user that there currently is a limitation of 4 hashtags
#12463 to increase the number of possible hashtags
#1096 is a related bug to add an option to follow hashtags

@GerryT11 GerryT11 closed this Nov 24, 2019
@unextro

This comment has been minimized.

Copy link

@unextro unextro commented Nov 25, 2019

It's not just that only first 4 apply. In my case, posts with other hashtags (not among the first 4) show up in the search column but they disappear once I refresh the page and only posts with the first 4 hashtags stay. It's still a bug.

@GerryT11

This comment has been minimized.

Copy link
Author

@GerryT11 GerryT11 commented Nov 25, 2019

After the comment by @unextro I reopen this bug again.

It's not just that only first 4 apply. In my case, posts with other hashtags (not among the first 4) show up in the search column but they disappear once I refresh the page and only posts with the first 4 hashtags stay. It's still a bug.

@GerryT11 GerryT11 reopened this Nov 25, 2019
@marrus-sh

This comment has been minimized.

Copy link
Contributor

@marrus-sh marrus-sh commented Nov 26, 2019

(The bug in this case is that Mastodon allows subscribing to more than 4 hashtags per column through websockets, but not fetching more than 4 hashtags per column on initial page load.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.