Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support groups #139

Open
cphuntington97 opened this issue Nov 5, 2016 · 71 comments
Open

Support groups #139

cphuntington97 opened this issue Nov 5, 2016 · 71 comments

Comments

@cphuntington97
Copy link

@cphuntington97 cphuntington97 commented Nov 5, 2016

support groups using bangtags

@Gargron
Copy link
Member

@Gargron Gargron commented Nov 5, 2016

I made a decision not to implement groups. They offer little benefit over a cost of added complexity, and the bangtag syntax personally irks me too.

@Gargron Gargron added the wontfix label Nov 5, 2016
@Gargron Gargron closed this Nov 7, 2016
alpaca-tc added a commit to pixiv/mastodon that referenced this issue Apr 24, 2017
Revert "Revert "Create component for announcements""
Merge pull request tootsuite#161 from pixiv/revert-160-feature/create_component_for_announcements
Revert "Create component for announcements"
Merge pull request tootsuite#160 from pixiv/feature/create_component_for_announcements
typo
Change announcement manager
Remove unused import
remove comment out
Create react-component for announcements
Merge pull request tootsuite#156 from pixiv/revert-155-fix_autosuggest_z_index
Revert "トゥートの登録フォームで長文を書いても、アナウンスパネルにかぶらないように"
Merge pull request tootsuite#155 from pixiv/fix_autosuggest_z_index
(origin/fix_autosuggest_z_index, fix_autosuggest_z_index) Add zindex style
(svg_encode) Merge pull request tootsuite#141 from pixiv/add_privacy_policy_for_sp
Fix title/ogp.
Fix text.
Merge pull request tootsuite#151 from pixiv/add_protocol
(origin/add_protocol, add_protocol) Add protocol
Merge pull request tootsuite#149 from pixiv/allow_5_megabytes
(origin/allow_5_megabytes, allow_5_megabytes) Reject large profile
Merge pull request tootsuite#148 from pixiv/notice_pixiv_link
(origin/notice_pixiv_link, notice_pixiv_link) pixivアカウントと連携した場合の注意を表記する
Merge pull request tootsuite#147 from pixiv/disable_two_factor_authentication
(origin/disable_two_factor_authentication, disable_two_factor_authentication) Hide two factor authentication if user is linked with pixiv account
二段階認証が有効な場合はpixiv連携できない
Merge pull request tootsuite#145 from pixiv/remove_announcements
(origin/remove_announcements, remove_announcements) Remove announcements on mobile
Merge pull request tootsuite#144 from pixiv/fix_sidebar_ex
Fix sidebar scroll css.
Merge pull request tootsuite#143 from pixiv/fix_sidebar_scroll
Merge pull request tootsuite#122 from pixiv/render_announcements
Render announcements
Make sideber scrollabled at setting page.
Merge pull request tootsuite#139 from pixiv/replace_mastodon_to_pawoo
Add sample text at view.
Add controller method.
Add endpoint.
Destroy InitialPasswordUsage
Remove unnecessary index
Expire cache of nginx
(origin/replace_mastodon_to_pawoo, replace_mastodon_to_pawoo) Replace 'Mastodon' -> 'Pawoo'
Update site_title 'Mastodon' -> 'Pawoo'
Replace 'Mastodon' with 'Pawoo'
Render pixiv url
Prevent destroy if user has initial_password_usage
Replace factory.dev with pawoo.dev
Add comment for normalize_username
Render error message when failed linking
Optimize query for finding by uid and provider
Update locale of oauth_authentication
Rename RedisCache -> RedisSessionStore
Enable popup signup sdk
Do not remove upcase
Replace :preload -> :includes
Refactor Form::OauthRegistration
Find oauth_authentication by uid
(hotfix_oauth_login) Merge pull request tootsuite#135 from pixiv/replace_toppage_image
Remove site_extended_description
Replace demo image
Revert cookie_store key
Fix text.
Revert "Add i18n-tasks to ci"
cookie_storeのキー名を変更
Merge pull request tootsuite#105 from pixiv/omniauth-pixiv
Merge pull request tootsuite#124 from pixiv/improve_top_page
(origin/improve_top_page, improve_top_page) Skip view spec for contact page
Improve home#show home#more
Merge pull request tootsuite#123 from pixiv/i18n-tasks
(origin/i18n-tasks) Add i18n-tasks to ci
(origin/omniauth-pixiv, omniauth-pixiv) Fixes undefined method error
日本語とスタイルを調整
Merge pull request tootsuite#100 from pixiv/fix/remove-unused-message
Fixed typo
Merge pull request tootsuite#113 from pixiv/omniauth-pixiv-with-badge
Add oauth authentication status badge to user page
Add oauth authentication status badge
Load oauth_authentications
Rename `ソーシャルログイン` -> `pixivアカウント連携`
Update secrets.yml
Fixes gemfiles
Update oauth_registration.rb
Add null constraint to initial_password_usages
Fixes specs
Do not delete oauth_authentication if user has initial_password_usage
Send reset password instruction if user has initial password
Send reset password instruction if user has initial password
Create InitialPasswordUsage for initial user
Create InitialPasswordUsage
Destroy OauthAuthentication that related with expired users
Update oauth registration form
signin popup
Add omniauth action buttons
autoresize textarea
replace oops image
media aspect ratio change to 16:9
Create OauthRegistrationsController
CookieStore can not store data because it is tiny
Clean redis data each test
Create Auth::OmniauthCallbacksController
Create Settings::OauthAuthenticationsController
Create OauthAuthentication
Install omniauth-pixiv
Feature/change displayname style (tootsuite#102)
Merge pull request tootsuite#76 from pixiv/feature/hide-follow-when-blocked
Merge pull request tootsuite#103 from pixiv/fsubal/fix-broken-account-description
Merge pull request tootsuite#66 from pixiv/fix/url_escape
add HTML escape test
put a comma after the last item
ブロックしているユーザーにフォローボタンを出さない
Merge pull request tootsuite#99 from pixiv/autoresize_textarea
autoresize textarea
replace oops image
謎の clear: both; を削除
Update accounts.scss
add tests
Remove unused translation
Merge pull request tootsuite#98 from pixiv/media_aspect_ratio_change_to_16_9
media aspect ratio change to 16:9
add rel=nofollow
fix character escaping in URL
Merge pull request tootsuite#90 from pixiv/sidekiq-statistic
Merge pull request tootsuite#96 from pixiv/admin_script
Destroy local account from admin page
Merge pull request tootsuite#92 from pixiv/fix/translation_ja_modal
about.termsにするとどうか?
フィードバックを受けて翻訳を微調整した
@joshp23
Copy link

@joshp23 joshp23 commented Jun 18, 2017

This is the main reason that I'm not using Mastadon. Groups are a wonderful feature of GNU Social, and I would love to see them implemented on Mastadon.

However, while that certainly does keep me from enjoying Mastadon, the root of the matter is that...

  1. This is an opinion (subjective) based exclusion of an established feature that many, myself included, find far more valuable than is implied above, and not at all visually irksome. "My personal, subjective opinion is better than yours because I hold it," is not a good reason to exclude an established feature set.
    • Also, it is entirely possible to avoid groups if you so choose when they are implemented.
  2. Treating subjective opinions as objective truths (ie, "It is my opinion that this provides little value, it is therefore a fact that this is so,") is just bad directional thinking.

This, being an old and closed issue, likely doesn't get the attention that it deserves, but I know that I am not the only one that holds this view.

At any rate, It would be great to see groups in Mastadon, please reconsider.

@Gargron
Copy link
Member

@Gargron Gargron commented Jun 29, 2017

Reopening, but not high priority.

@Gargron Gargron reopened this Jun 29, 2017
@ykzts ykzts added enhancement and removed wontfix labels Jun 29, 2017
abcang pushed a commit to pixiv/mastodon that referenced this issue Jul 3, 2017
@schiessle
Copy link

@schiessle schiessle commented Sep 16, 2017

Coming from GNU Social I also miss groups a lot. It is a easy way to exchange messages about a specific topic without the need to follow all the people (and also get all the unrelated messages).

But after thinking about it for a while I wonder why there is this arbitrary distinction between groups and hash tags? Maybe it would be better to simply add the possibility to follow hash tags, similar to Diaspora. It achieves the same but makes it probably easier to use and understand for new users.

@Cassolotl
Copy link

@Cassolotl Cassolotl commented Sep 16, 2017

Maybe it would be better to simply add the possibility to follow hash tags, similar to Diaspora. It achieves the same but makes it probably easier to use and understand for new users.

I agree! And @schiessle, that's #1096, if that helps at all.

@joshp23
Copy link

@joshp23 joshp23 commented Sep 16, 2017

I think that either option (following hashtags or creating groups) is a good idea. However, groups has a potential edge in viewership/participant restriction.

takayamaki pushed a commit to takayamaki/mastodon that referenced this issue Oct 1, 2017
@fsnk
Copy link

@fsnk fsnk commented Oct 11, 2017

I would very much like groups.

I think they would help users find other people who share their interests, especially since Mastodon by design limits discoverability by not allowing full text search, and other social media platforms have been training users off hashtagging. (Twitter no longer requires a post contain the actual hashtag in order to appear in the hashtag search results.)

@schiessle
Copy link

@schiessle schiessle commented Oct 12, 2017

I heard rumors that groups might come in one of the next releases. 😉
It would be good to learn from the mistakes of status.net aka GNU Social which are in my opinion:

  • on GNU Social there can't be a group "foo" and a user "foo". Would be great if the namespace would be decoupled so that it is possible to have users and groups with the same name.

  • GNU Social has group aliases. So you can have for example a group for all FOSS enthusiasts and let them address the group as !FreeSoftware !OpenSource !FOSS or !FLOSS. I think this is great and useful in many areas. But on GNU Social this aliases are only available on the server which hosts the group, all other servers only know the main group name. If we have group aliases it would be great if they would federate as well.

@deutrino
Copy link

@deutrino deutrino commented Nov 15, 2017

There is a fair amount of discussion on the merit of !groups on #1096 in case anybody missed the link to that issue upthread.

@Cassolotl Cassolotl mentioned this issue Nov 26, 2017
1 of 2 tasks complete
@Cassolotl
Copy link

@Cassolotl Cassolotl commented Mar 4, 2018

I note that option to follow hashtags 1096 Ability to subscribe or follow tags #945 has a lot more thumbs-ups than this one, despite this issue being much older. I'm wondering if there is a plan to implement both? I know that !groups is on the roadmap for the near future, and I'm concerned that that's instead of the ability to follow hashtags?

Edit: It was pointed out that #1096 is a duplicate, but I think my point still holds! #1096 has 35 👍 and #945 has 13.

@deutrino
Copy link

@deutrino deutrino commented Mar 4, 2018

Is #945 an implementation of #1096?

Also, there's the wrinkle of groups, as implemented in gnusocial, making sure the messages sent to the !group will federate to all subscribers. Following hashtags doesn't do that.

@Vitalicus

This comment was marked as off-topic.

@opitux

This comment was marked as off-topic.

@oiceberg
Copy link

@oiceberg oiceberg commented Feb 28, 2020

There is an instance (gab dot com) who uses Mastodon's but, apparently, doesn't compliance with Mastodon's GNU AGPLv3 license. In my opinion they made a very good implementation of Groups in their Mastodon instance, but probably it's source code is not shared, violating the GNU AGPLv3 license.

I'll attach here 6 print screens of Groups implementation in that instance:

  1. Groups / Featured.
  2. Groups / Member.
  3. Inside a group / Members.
  4. Inside a group / Posts (take attention for the most recent toot).
  5. Inside a group / Posts / Filter turned on.
  6. That most recent toot posted in the group how it's viewed on the timeline of the user who posted it, making explicit reference to the group in which it was posted.

The red squares are on my own emphasizing the highlights of the respective screen.

In summary, a toot posted inside a group is viewed in both the group's feed and the user's feed.

I hope it could inspire the community to implement Groups funcionality. <3

mastodon-groups-01-featured-view
mastodon-groups-02-member-view
mastodon-groups-03-inside-a-group-members-view
mastodon-groups-04-inside-a-group-posts-view
mastodon-groups-05-inside-a-group-posts-view-with-filter-on
mastodon-groups-06-toot-posted-in-a-group-on-user-timeline-view

@jelutz77
Copy link

@jelutz77 jelutz77 commented Feb 28, 2020

Probably? Sounds like prejudice to me. https://code.gab.com/gab/social/gab-social/

@pwFoo
Copy link

@pwFoo pwFoo commented Feb 28, 2020

Public / private groups ist a important feature I would need. Tested mastodon, misskey and search more systems...
Maybe I need to take a look into gab...?!

@JamesTheAwesomeDude
Copy link

@JamesTheAwesomeDude JamesTheAwesomeDude commented May 5, 2020

I wonder why there is this arbitrary distinction between groups and hash tags? Maybe it would be better to simply add the possibility to follow hash tags, similar to Diaspora.

I do think you're precisely right, schiessle, at least as far as Open groups are concerned; nemobis brings up

Groups only need to be something like that with some possibility to moderate membership.

I think the crux of this issue is Access Controls:

A "group"...

  • may restrict who can post in it (beyond the base restrictions of the server)
  • determines who can view posts in it (independently of the base restrictions of its posters)
    • trivial by comparison: requires opt-in to view technically-public posts in it

Also, I want to signal-boost @sgenoud's above comment for providing us inspiration both motivational and technical.

@JamesTheAwesomeDude
Copy link

@JamesTheAwesomeDude JamesTheAwesomeDude commented May 5, 2020

There is an instance ... who uses Mastodon's [protocol,] but, apparently, doesn't [comply] with Mastodon's GNU AGPLv3 license

[screenshots]

Huh, it looks like that instance really has groups working well!

Interestingly, the AGPL (assuming that instance's code is a derivative of Mastodon, and not merely compatible,) mandates they release their source:

if you modify the Program, your modified version must prominently offer all users interacting with it remotely through a computer network (if your version supports such interaction) an opportunity to receive the Corresponding Source of your version by providing access to the Corresponding Source from a network server at no charge:

So, unless one of the existing "plugins" proves mature enough to integrate, might it be worth seeing what pieces we can salvage off the rogue instance's codebase?

(Though, I don't suppose it'd be worth following-through with a lawsuit if they really are, truly violating the AGPL...)

@SteveM2020
Copy link

@SteveM2020 SteveM2020 commented Jun 21, 2020

I'm new to Mastodon. I saw two groups discussing environmental issues. The first one said it didn't recognize my email mastodon email address. So I tried my real email address but that didn't work either.

Then I tried to join the second group. It said to login. It wouldn't take my mastodon email address. Said it was already taken. When I tried to use my real email address it said that was taken too.

So I looked for a mastodon support group. Guess what? Yup. Both my email addresses were taken.

Other web tutorials discussed programming servers and stuff I don't understand. I just wanted to join a couple of groups. None of them carry the basic stuff. They assume everyone knows. Am I the only person on the Internet who doesn't know how to join a group?

@bleonard252
Copy link

@bleonard252 bleonard252 commented Jun 21, 2020

I'm new to Mastodon. I saw two groups discussing environmental issues. The first one said it didn't recognize my email mastodon email address. So I tried my real email address but that didn't work either.

Then I tried to join the second group. It said to login. It wouldn't take my mastodon email address. Said it was already taken. When I tried to use my real email address it said that was taken too.

So I looked for a mastodon support group. Guess what? Yup. Both my email addresses were taken.

Other web tutorials discussed programming servers and stuff I don't understand. I just wanted to join a couple of groups. None of them carry the basic stuff. They assume everyone knows. Am I the only person on the Internet who doesn't know how to join a group?

Well the problem is there's no such thing as groups in Mastodon. What are you doing?

@ryliejamesthomas
Copy link

@ryliejamesthomas ryliejamesthomas commented Jun 23, 2020

@SteveM2020 I think you've misunderstood the term 'group' in this context.

This issue is not about groups of people, it's about incorporating a feature called 'groups' which existed on another social media service, where people could could use a feature similar to tags but with the benefit of curation (that's a simplification, of course). It is also not about 'support groups'.

You've also misunderstood that a Fediverse address is not the same as an email address, so can not be used interchangeably.


Shame on the people giving them a thumbs-down.

@SteveM2020
Copy link

@SteveM2020 SteveM2020 commented Jun 23, 2020

Thank you. I agree. I'm not familiar enough with it and have misunderstood the mechanics of how this platform works.

@duven87
Copy link

@duven87 duven87 commented Jun 23, 2020

It's a great shame, really. I've been waiting a year for the groups to be integrated and nothing. Everything's the same.
Luckily, the timeslines has been simplified to a column, as I said a year ago.
Other Mastodon-based platforms like gab already have them integrated.
Personally, I don't like gab or Minds because the users are right-wing politicians and I can't find groups according to my interests.
I would like so much to leave Facebook and set up my own mastodon/pleroma instance but without groups I still don't have the motivation to do it.

@SteveM2020
Copy link

@SteveM2020 SteveM2020 commented Jun 24, 2020

Groups would be nice. I have groups on FB as well. I really liked Google+ and haven't found a good replacement for it yet. Ya' I don't cater to the right wing ideologies either. They seem to becoming more and more popular with hate/racism, white privileged extremists.

@savageawakening
Copy link

@savageawakening savageawakening commented Jul 29, 2020

I agree that groups would help in driving adoption. My use-case is to replace facebook as my home town's online hub where they use separate facebook groups for buy and sell, auctions, roommate search and general discussions. While these could in theory be different hashtags, groups are a familiar concept, especially for the older generation where they can simply join (or even be invited to) a group and they will be automatically following whatever is posted to said group.

@JamesTheAwesomeDude
Copy link

@JamesTheAwesomeDude JamesTheAwesomeDude commented Jul 30, 2020

I really want to see this happen / I'll be really annoyed if I end up having to spend the social momentum of my friend group's Facebook-escape-velocity on joining freaking Gab, with its stigma around its developers' political leanings.

Please, can someone just do this already? Gab's had this feature working great for…how many years, now? And we've had how many PRs turned down for insufficient quality? (Remember, it's 100% cool and nice to just plagiarize the code off Gab for this; I'm not sure why there hasn't been more of a focus on re-integrating their improvements—the AGPL gives us that right.)

I've started a bounty on this; I'll likely contribute more. If there's any formal way to hand off control to @tootsuite on this, lmk.

https://www.paypal.com/pools/c/8rgMfLPiSk

This is the killer feature, IMO, in terms of starting to "replace" parts of the existing Social Media ecosystem. Every other platform [Facebook, Discord, MeWe, GNU Social, Diaspora, Gab, etc.] has something equivalent to this, but none are open-source, user-friendly, and politically uncancelled. Y'all have a really unique, important position, and it kills me that it's not becoming what it could be. If there's any particular/given monetary threshold you think would get this done, I'll try to help reach it.

@mikestaub
Copy link

@mikestaub mikestaub commented Jul 30, 2020

@JamesTheAwesomeDude the code for gab.com is not open-source.

I agree this is by far the most important missing feature in the Fediverse ( just pitched in $100 to the bounty ) but it is not so simple. We need to think through the design carefully.

Here is the ActivityPub thread if you want to follow along: https://socialhub.activitypub.rocks/t/groups-implementation/591

@JamesTheAwesomeDude
Copy link

@JamesTheAwesomeDude JamesTheAwesomeDude commented Jul 30, 2020

@mikestaub

the code for gab.com is not open-source.

I believe this is false; I actually found it while trying to confirm whether or not we could re-integrate the code (since that's the whole point of the GNU license family, especially the AGPL).

Though, it doesn't answer the crucial question of whether it'd be efficient to merge their code "back" in, or just to re-implement the feature ourselves; their codebase diverges ever-further.

is not so simple. We need to think through the design carefully.

I wonder whether there's anything to be gained from, if not salvaging code directly, at least looking to how they did it for architectural inspiration—as oiceberg notes above, whatever they've done seems to have worked really well and remains an in-tree, supported feature to this day. There's certainly something to be said for refactoring/reimplementing known-good code/architectures, rather than re-inventing wheels. (Not to denigrate the existing contributed implementations!)

[ETA: “Why not just use [existing feature]?”]

@JamesTheAwesomeDude
Copy link

@JamesTheAwesomeDude JamesTheAwesomeDude commented Nov 14, 2020

Here's a thread with some boring-but-solid exposition and exploration of what this would entail:

https://git.pleroma.social/pleroma/pleroma-meta/-/issues/14

@duven87
Copy link

@duven87 duven87 commented Dec 30, 2020

Still without this function? today, reading articles, "Mewe" appeared to me, unfortunately it is not decentralized but I remembered Mastodon because of the lack of groups.

@trymeouteh
Copy link

@trymeouteh trymeouteh commented Jan 12, 2021

I big feature missing in Mastodon is the ability to create private and public groups. And have admin, moderators and users in the groups with permissions on each tier. This would be an amazing thing to have since it will allow anyone to have a Mastodon account and to be able to join a group hosted on any instance especially exclusive groups.

There are so many groups on Facebook that are exclusive meaning you need to be a member to join and I do not bother with them since I do not like Facebook and its privacy. If Mastodon allows for this, no need to signup on a exclusive instance and have a second account, just use your account of whatever instance and connect to a exclusive private group on another instance.

@SteveM2020
Copy link

@SteveM2020 SteveM2020 commented Jan 12, 2021

This may be related and of value.

Some classes, my daughter takes at university, have study groups setup on Discord. I asked her what that was like, and she loaded Discord in my browser. She said, "Look, you already have an account!" I had an invitation sitting there from MintCast, a communications and discussion channel for Linux Mint users.

The odd thing about it is, the invitation was sent through Mastodon. It seems I had joined halfway, got stuck someplace and gave up on it. But Mintcast is a group on Discord. One needs to be invited to join. So it would seem you can invite mastodon users to discord, and setup a group there.

I don't know anything about Discord at this point. But googling for information about groups brought me up a page that describes groups on Mastodon. I'll share the link with you in case you want to see it. The page is marketing something or another, but if you overlook that, the info seems good about groups.

https://chameleoncollective.com/6-steps-engaged-discord-community-brand/

Perhaps an interim solution might be utilizing both services.

@1337god
Copy link

@1337god 1337god commented Jan 15, 2021

I made a decision not to implement groups. They offer little benefit over a cost of added complexity, and the bangtag syntax personally irks me too.

You should look at https://qoto.org/web/group_directory for example, the groups look like a really nice implementation.

@illspirit
Copy link

@illspirit illspirit commented Jan 19, 2021

This is a needed feature.

@Jastiva
Copy link

@Jastiva Jastiva commented Jan 19, 2021

We have to implement groups in the code. If not prepare to fork. (again)

@oiceberg
Copy link

@oiceberg oiceberg commented Jan 20, 2021

@JamesTheAwesomeDude
Copy link

@JamesTheAwesomeDude JamesTheAwesomeDude commented Jan 21, 2021

@oiceberg

Gab implementation of great. The source code is available in Gab's repository. Would it be so Herculean to reuse their code?

It sort of would, actually; Gab is no longer federated, so they're basically, now, just a nominally (and decreasingly) open-source Facebook. Since they didn't have to even think about issues of how to manage group privacy and permissions over the network, they were able to just write all the code to trust itself and it's done. Oh, the tactical benefits of being a centralized platform-as-a-service…

There is some bureaucratic problem to decide about it and open a request to this task?

The AGPL, thankfully, prevents any legal problems; the only "bureaucratic" issue is that it's a big engineering project that takes a lot of man-hours to build what, on the surface, "seems" like a small feature. See the thread I linked earlier for some discussion illustrating this. So, internally, it's low-priority due to a low perceived cost-benefit ratio.

(And, now that Gab is out of the running for a decentralized social media platform, I think it's safe to say that the pressure on this issue is even lower than before…)

@raphaeljolivet
Copy link

@raphaeljolivet raphaeljolivet commented Jan 27, 2021

You should look at https://qoto.org/web/group_directory for example, the groups look like a really nice implementation.

Hi, thanks for this info !
So indeed it shows that groups are up and running !

More info here :
https://groups.qoto.org/about/more

Source code for groups server :
https://git.qoto.org/qoto/qoto-groups (broken link)

Source code for Qoto :
https://git.qoto.org/qoto

We can ask the main developer for details about the implementation and ActivityPub support.
I understand that groups are public for now : it still addresses most of usages.
We should start by integrating this feature properly.

On a side note, I feel that Mastodon is forked a LOT by different admins, adding small features. The pace of development of Mastodon is not up to the vitality of the community. This is a smell that it badly lacks a plugin system.
I would push for this issue : #7717

@Gargron : What do you think ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet