/mastodon

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications fail to load #1491

Closed
riking opened this Issue Apr 11, 2017 · 16 comments

Comments

Assignees
No one assigned
Labels
bug expertise wanted ui
Projects
None yet
Milestone
No milestone
8 participants
@riking @wxcafe @mjankowski @Gargron @Fastidious @Wonderfall @Fusl @ericblade
@riking
Copy link

riking commented Apr 11, 2017 •
edited

Bad commit 12f72e1

application-40ef2e74c5e2f7d364d4364f187e18e4b1cd3a785debb8a00a1532ba1e37b483.js:39
TypeError: status.getIn is not a function
    at Object.render (application-40ef2e74c5e2f7d364d4364f187e18e4b1cd3a785debb8a00a1532ba1e37b483.js:30)
    at ReactCompositeComponentWrapper._renderValidatedComponentWithoutOwnerOrContext (application-40ef2e74c5e2f7d364d4364f187e18e4b1cd3a785debb8a00a1532ba1e37b483.js:702)
    at ReactCompositeComponentWrapper._renderValidatedComponent (application-40ef2e74c5e2f7d364d4364f187e18e4b1cd3a785debb8a00a1532ba1e37b483.js:702)
    at ReactCompositeComponentWrapper.performInitialMount (application-40ef2e74c5e2f7d364d4364f187e18e4b1cd3a785debb8a00a1532ba1e37b483.js:702)
    at ReactCompositeComponentWrapper.mountComponent (application-40ef2e74c5e2f7d364d4364f187e18e4b1cd3a785debb8a00a1532ba1e37b483.js:702)
    at Object.mountComponent (application-40ef2e74c5e2f7d364d4364f187e18e4b1cd3a785debb8a00a1532ba1e37b483.js:1110)
    at ReactCompositeComponentWrapper.performInitialMount (application-40ef2e74c5e2f7d364d4364f187e18e4b1cd3a785debb8a00a1532ba1e37b483.js:702)
    at ReactCompositeComponentWrapper.mountComponent (application-40ef2e74c5e2f7d364d4364f187e18e4b1cd3a785debb8a00a1532ba1e37b483.js:702)
    at Object.mountComponent (application-40ef2e74c5e2f7d364d4364f187e18e4b1cd3a785debb8a00a1532ba1e37b483.js:1110)
    at ReactCompositeComponentWrapper.performInitialMount (application-40ef2e74c5e2f7d364d4364f187e18e4b1cd3a785debb8a00a1532ba1e37b483.js:702)
(anonymous) @ application-40ef2e74c5e2f7d364d4364f187e18e4b1cd3a785debb8a00a1532ba1e37b483.js:39
  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
@wxcafe

This comment has been minimized.

Sign in to view
Copy link
Contributor

wxcafe commented Apr 11, 2017 •
edited

screenshot from 2017-04-11 01-57-15 Part of the nginx log that might be related, and

screenshot from 2017-04-11 01-37-59

console log in firefox.

Seems like other people have the same problem https://ohai.su/users/lutoma/updates/146

[EDIT] nginx is no longer showing me these errors and yet the problem persists

@wxcafe wxcafe added bug priority - high ui expertise wanted labels Apr 11, 2017

@wxcafe

This comment has been minimized.

Sign in to view
Copy link
Contributor

wxcafe commented Apr 11, 2017

This was following upgrading to master from v1.1.1. I basically followed the production guide:

  • services stop
  • git pull
  • rbenv install 2.4.1
  • gem install bundler
  • bundle install
  • RAILS_ENV=production bundle exec rails db:migrate
  • RAILS_ENV=production bundle exec rails assets:precompile
  • services start
@mjankowski

This comment has been minimized.

Sign in to view
Copy link
Collaborator

mjankowski commented Apr 11, 2017

Possibly related commit (which is after 1.1.1) - 12f72e1
@wxcafe

This comment has been minimized.

Sign in to view
Copy link
Contributor

wxcafe commented Apr 11, 2017

Rerolling to v1.1.1 AND downgrading the assets fixes it (I'm dumb)

riking referenced this issue Apr 11, 2017

@Gargron
When avatar/header are GIF, generate static versions (#1428) 
* When avatar/header are GIF, generate static versions.
Account API returns "avatar"/"avatar_static", "header"/"header_static"
Static version is the same as original for other cases
Web UI de-animates avatars in toots, lists of users

Fix #441, fix #596, prerequisite for #1064

* Fix JS test

* Add rake task to generate static avatars/headers from GIF ones, add test
Loading status checks…
12f72e1
@Gargron

This comment has been minimized.

Sign in to view
Copy link
Member

Gargron commented Apr 11, 2017

Possibly introduced in 2810013 (unlikely that it's 12f72e1)
@riking

This comment has been minimized.

Sign in to view
Copy link
Author

riking commented Apr 11, 2017 •
edited

Notifications were still streaming, and working in the Android app. Unlikely that a server change would do that.

And it seems I accidentally hid it, but the actual error is TypeError: status.getIn is not a function - I'm not sure how it could be anything else?

@riking riking referenced this issue Apr 11, 2017

Closed

Integration test for notifications #1499

@Fastidious

This comment has been minimized.

Sign in to view
Copy link

Fastidious commented Apr 11, 2017 •
edited

Same happening to my instance (“Ops! An unexpected error occurred.” message). Notifications are blank. Running latest master, dockerised.
@Wonderfall

This comment has been minimized.

Sign in to view
Copy link
Contributor

Wonderfall commented Apr 11, 2017

Reverted to 0687ab8 and it works again.
@riking

This comment has been minimized.

Sign in to view
Copy link
Author

riking commented Apr 11, 2017 •
edited

looking over my draft of an integration test #1499 , Follow notifications don't have a status - could that be it?
@Fusl

This comment has been minimized.

Sign in to view
Copy link

Fusl commented Apr 11, 2017

@riking That seems to be the case. My notifications are loading until I scroll down to where the latest follow notification is at which point it stops loading and fails with the error TypeError: status.getIn is not a function.

@wxcafe wxcafe referenced this issue Apr 11, 2017

Closed

Notification column stopped working, assets not available #1521

1 of 1 task complete

@wxcafe wxcafe changed the title Notifications fail to load (social.wxcafe.net) Notifications fail to load Apr 11, 2017

@Fastidious

This comment has been minimized.

Sign in to view
Copy link

Fastidious commented Apr 11, 2017

Could someone post the temporary fix for this? Will a git revert 0687ab8 be the way to go? Please advise.
@wxcafe

This comment has been minimized.

Sign in to view
Copy link
Contributor

wxcafe commented Apr 11, 2017

@Fastidious git checkout 0687ab8, RAILS_ENV=production bundle exec rails db:migrate, RAILS_ENV=production bundle exec rails assets:precompile, systemctl restart 'mastodon-*'
@Fastidious

This comment has been minimized.

Sign in to view
Copy link

Fastidious commented Apr 11, 2017 •
edited

@wxcafe I am on Docker. For anyone wanting to temporarily fix this using Docker, the steps are:

  • git checkout 0687ab8
  • docker-compose build
  • docker-compose run --rm web rails db:migrate
  • docker-compose run --rm web rails assets:precompile
  • docker-compose up -d

@Fastidious Fastidious referenced this issue Apr 11, 2017

Merged

When avatar/header are GIF, generate static versions #1428

@Gargron

This comment has been minimized.

Sign in to view
Copy link
Member

Gargron commented Apr 11, 2017

I found the source of the issue, preparing a PR.

Gargron added a commit that referenced this issue Apr 11, 2017

@Gargron
Fix #1491 - Fix broken notifications, broken Link header parsing for … 
…exclude_types
Loading status checks…
e7953d9

Gargron added a commit that referenced this issue Apr 11, 2017

@Gargron
Fix #1491 - Fix broken notifications, broken Link header parsing for … 
…exclude_types
Loading status checks…
ca5d879

@davidcelis davidcelis referenced this issue Apr 11, 2017

Closed

Repeated "401 The access token is invalid" errors for "Home" and "Notifications" streams in Safari #1490

1 of 1 task complete
@ericblade

This comment has been minimized.

Sign in to view
Copy link
Contributor

ericblade commented Apr 11, 2017

fwiw, i'm only seeing it when i attempt to search something. will check out the fix.

@ericblade ericblade referenced this issue Apr 11, 2017

Closed

follow and followers broken on web UI #1566

@ericblade

This comment has been minimized.

Sign in to view
Copy link
Contributor

ericblade commented Apr 11, 2017

appears to be fixed with that commit

ericblade pushed a commit to ericblade/mastodon that referenced this issue Apr 11, 2017

@Gargron Eric Blade
Fix tootsuite#1491 - Fix broken notifications, broken Link header par… 
…sing for exclude_types
6a95d3f

ericblade pushed a commit to ericblade/mastodon that referenced this issue Apr 11, 2017

@Gargron Eric Blade
Fix tootsuite#1491 - Fix broken notifications, broken Link header par… 
…sing for exclude_types
5d61fec

@Gargron Gargron closed this in b22b2cb Apr 11, 2017

mbilokonsky added a commit to mbilokonsky/mastodon that referenced this issue Apr 11, 2017

@Gargron @mbilokonsky
Fix tootsuite#1491 - Fix broken notifications, broken Link header par… 
…sing for exclude_types (tootsuite#1548)
c6d34ec

@raymestalez raymestalez referenced this issue Apr 12, 2017

Closed

Streaming errors. "Error: Invalid access token" #1615

1 of 1 task complete

Nyoho pushed a commit to Nyoho/mastodon that referenced this issue Apr 25, 2017

@Gargron
Fix tootsuite#1491 - Fix broken notifications, broken Link header par… 
…sing for exclude_types (tootsuite#1548)
d07ca90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment