New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All gif avatars are animating by default #3262

Closed
Ragzouken opened this Issue May 23, 2017 · 10 comments

Comments

Projects
7 participants
@Ragzouken

Ragzouken commented May 23, 2017

All gif avatars are animating by default, and pause when you hover over them.

#2846 seems related but seems to be only for specific avatars. For me all avatars are animating


  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
  • This bug happens on a tagged release and not on master (If you're a user, don't worry about this).
@Gargron

This comment has been minimized.

Show comment
Hide comment
@Gargron

Gargron May 23, 2017

Member

It "auto play animated GIFs" option turned on or off in your preferences?

Member

Gargron commented May 23, 2017

It "auto play animated GIFs" option turned on or off in your preferences?

@Ragzouken

This comment has been minimized.

Show comment
Hide comment
@Ragzouken

Ragzouken May 23, 2017

I want animated gifs to play, just not avatars

Ragzouken commented May 23, 2017

I want animated gifs to play, just not avatars

@Ragzouken

This comment has been minimized.

Show comment
Hide comment
@Ragzouken

Ragzouken May 23, 2017

(this was working before)

Ragzouken commented May 23, 2017

(this was working before)

@Gargron

This comment has been minimized.

Show comment
Hide comment
@Gargron

Gargron May 23, 2017

Member

I am asking because it is "on" for me and all avatars are paused until hovered (correctly), so it's very weird.

Member

Gargron commented May 23, 2017

I am asking because it is "on" for me and all avatars are paused until hovered (correctly), so it's very weird.

@beatrix-bitrot

This comment has been minimized.

Show comment
Hide comment
@beatrix-bitrot

beatrix-bitrot May 23, 2017

Collaborator

@Gargron i can confirm i have this issue as well (for quite a while now). latest chrome on win10. i would test on FF but something about my instances CSP seems to prevent my instance for loading for me in FF at the moment...

Collaborator

beatrix-bitrot commented May 23, 2017

@Gargron i can confirm i have this issue as well (for quite a while now). latest chrome on win10. i would test on FF but something about my instances CSP seems to prevent my instance for loading for me in FF at the moment...

@Ragzouken

This comment has been minimized.

Show comment
Hide comment
@Ragzouken

Ragzouken May 23, 2017

i have the setting off

Ragzouken commented May 23, 2017

i have the setting off

@joyeusenoelle

This comment has been minimized.

Show comment
Hide comment
@joyeusenoelle

joyeusenoelle May 23, 2017

Contributor

Observed in Safari 10.0.3 on Mac OS X 10.11.6 and in Chrome 58.0.3029.110 on Windows 8.

With or without the "auto-play animated gifs" toggle selected, animated avatars display the same behavior:

  1. When first loaded, an animated-gif avatar animates fully.
  2. When I hover the mouse over it, it continues animating.
  3. As soon as I unhover the mouse, it returns to frame 1 and stops animating.
  4. Thereafter, hovering the mouse over the avatar animates it, and unhovering causes it to return to frame 1 and stop animating.

This must be done for each instance of a given avatar; for example, if I have multiple posts by https://mastodon.social/@jk on my timeline, each post's avatar will animate independently until I've hovered over it, regardless of whether I've hovered over the other posts' avatars.

My understanding is that the behavior demonstrated in point 4 is the expected and planned behavior, but that 1 is unexpected and unplanned.

EDIT: Two additional points:

  1. This occurs in both mobile (single-column) and web (multi-column) views.
  2. I can confirm that on elekk.xyz, which is still running 1.3.3, avatars correctly do not animate until I mouse over them, in both Safari and Chrome.
Contributor

joyeusenoelle commented May 23, 2017

Observed in Safari 10.0.3 on Mac OS X 10.11.6 and in Chrome 58.0.3029.110 on Windows 8.

With or without the "auto-play animated gifs" toggle selected, animated avatars display the same behavior:

  1. When first loaded, an animated-gif avatar animates fully.
  2. When I hover the mouse over it, it continues animating.
  3. As soon as I unhover the mouse, it returns to frame 1 and stops animating.
  4. Thereafter, hovering the mouse over the avatar animates it, and unhovering causes it to return to frame 1 and stop animating.

This must be done for each instance of a given avatar; for example, if I have multiple posts by https://mastodon.social/@jk on my timeline, each post's avatar will animate independently until I've hovered over it, regardless of whether I've hovered over the other posts' avatars.

My understanding is that the behavior demonstrated in point 4 is the expected and planned behavior, but that 1 is unexpected and unplanned.

EDIT: Two additional points:

  1. This occurs in both mobile (single-column) and web (multi-column) views.
  2. I can confirm that on elekk.xyz, which is still running 1.3.3, avatars correctly do not animate until I mouse over them, in both Safari and Chrome.
@unarist

This comment has been minimized.

Show comment
Hide comment
@unarist

unarist May 25, 2017

Collaborator

The default value of state.hovering on Account component seems to be changed to true at 2991a7c#diff-50de755057c03939d93e8c516237b08a.

@ykzts Is this change intended?

Collaborator

unarist commented May 25, 2017

The default value of state.hovering on Account component seems to be changed to true at 2991a7c#diff-50de755057c03939d93e8c516237b08a.

@ykzts Is this change intended?

@ykzts

This comment has been minimized.

Show comment
Hide comment
@ykzts

ykzts May 25, 2017

Collaborator

@unarist

The default value of state.hovering on Account component seems to be changed to true at 2991a7c#diff-50de755057c03939d93e8c516237b08a.

@ykzts Is this change intended?

No. This is my mistake.

Collaborator

ykzts commented May 25, 2017

@unarist

The default value of state.hovering on Account component seems to be changed to true at 2991a7c#diff-50de755057c03939d93e8c516237b08a.

@ykzts Is this change intended?

No. This is my mistake.

@Ragzouken

This comment has been minimized.

Show comment
Hide comment
@Ragzouken

Ragzouken Dec 16, 2017

this seems to have returned

Ragzouken commented Dec 16, 2017

this seems to have returned

@wxcafe wxcafe reopened this Dec 16, 2017

@Gargron Gargron closed this Feb 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment