New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No notifications in notifications tab for follow requests #455

Open
nikkisquared opened this Issue Jan 10, 2017 · 10 comments

Comments

Projects
None yet
8 participants
@nikkisquared

nikkisquared commented Jan 10, 2017

If your account is private, and somebody sends you a follow request, there is no notification for this happening in the notifications tab. Having emails turned on for follow requests works fine, but it's strange for follow requests to not give a notification in Mastodon, especially when follows on a non-private account do.

alpaca-tc pushed a commit to pixiv/mastodon that referenced this issue Jun 15, 2017

@Gargron

This comment has been minimized.

Member

Gargron commented Jun 29, 2017

This has been a deliberate choice, at the time welcomed by users. The idea is that if your account is locked, you don't want to be bothered, and having follow requests in a place where you can look when you want it, rather than being demanded to look at it, is better.

If there is a significant movement for changing this, it would be simple enough to do, since currently follow requests are deliberately filtered out of the notifications column.

@nightpool

This comment has been minimized.

Collaborator

nightpool commented Jun 29, 2017

maybe make this opt-in? So follow requests are by default filtered out (client-side, using the existing notif filter stuff) but can be enabled?

@nightpool

This comment has been minimized.

Collaborator

nightpool commented Jun 29, 2017

I'm not entirely sold on the idea that this is the best default though, so maybe it should just be opt-out.

@Cassolotl

This comment has been minimized.

Cassolotl commented Jul 7, 2017

How about a little number next to "Follow Requests" in the Getting Started menu? The same colour as the rest of the text, just a little number in brackets - so you only see it when your fourth column is empty, and it's fairly discreet but you can see it without having to click anything?

screen_shot_2017-07-07_at_12_03_19

Edit May 2018: This has now been added!

@wxcafe

This comment has been minimized.

Contributor

wxcafe commented Sep 26, 2017

it should deffo be opt-out imo and it really needs to exist yeah

abcang added a commit to pixiv/mastodon that referenced this issue Oct 19, 2017

@rakiru

This comment has been minimized.

rakiru commented Nov 7, 2017

I completely missed that follow requests were filtered out from notifications. I considered this surprising behaviour, since everything else appears to show a notification, including regular follows, and smaller actions such as favouriting toots, as well as there being toggles to filter each of these things out. I also find it inconvenient as I have to check it manually every so often, whereas every other notification I get live in the pinned notifications column.

I find most of Mastodon UI intuitive, but this is one of a few things that I only stumbled on by chance and never would have guessed.

@Cassolotl

This comment has been minimized.

Cassolotl commented Nov 7, 2017

Yeah that's a good point - if users want to be able to not see follow requests it can be a notification, and then in the notifications toggle menu people should be able to toggle them off.

akihikodaki pushed a commit to kagucho/mastodon that referenced this issue Jan 21, 2018

Improved (tootsuite#455)
* Delete mastofed.png

* Improved

Make the instance and Mastodon logo one
@dariusk

This comment has been minimized.

dariusk commented Aug 16, 2018

For any instance admins looking at this and needing a solution for their users, I have a fix (commit) that you should be able to cherry-pick into into v2.4.3. The solution I came up with is not a full solution as it doesn't put the follow requests into the notifications stream, but it does at least surface the total number of follow requests in a more noticeable place (right under the TOOT button).

friendcamp@11987c9

How to "install", assuming you are not using Docker

Uh don't do this if you're not comfortable with like, resolving potential merge conflicts on upgrade to 2.4.5 or whatever the next release is.

cd ~/live
git checkout whatever-branch-you-normally-run-mastodon-from
git remote add friendcamp https://github.com/friendcamp/mastodon.git
git branch friendcamp
git checkout friendcamp
git pull friendcamp friendcamp-2.4.3
git checkout whatever-branch-you-normally-run-mastodon-from
git cherry-pick 11987c9255da1f982bcf4eb17d4fe4ee2c99c18a

Then just recompile your assets with RAILS_ENV=production bundle exec rails assets:precompile and restart your mastodon services.

If you want to undo this change, git reset --hard HEAD^ will do the trick assuming you haven't made any other changes since the cherry-pick command.

Here's a preview image (ignore the bad pluralization, that is fixed in the commit now).

image

@nightpool

This comment has been minimized.

Collaborator

nightpool commented Aug 16, 2018

@dariusk

This comment has been minimized.

dariusk commented Aug 16, 2018

In v2.4.3 the only indication available is inside the body of the Follow Requests item in the Getting Started menu, nothing on tab bar itself. So on mobile you need to manually hit the hamburger icon and then you can see if you have any requests or not. That's what my users wanted changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment