Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted statuses get repopulated #5059

Closed
nightpool opened this issue Sep 23, 2017 · 0 comments
Closed

Deleted statuses get repopulated #5059

nightpool opened this issue Sep 23, 2017 · 0 comments
Labels
api REST API, Streaming API, Web Push API bug Something isn't working work in progress Not to be merged, currently being worked on

Comments

@nightpool
Copy link
Member

Occasionally after deleting a status, users are seeing it reappear in their feeds:

image

Current theory is that this happens due to the signature-based federation stuff. something like:

  1. post 1 from server A -> B
  2. simultaneously:
    a. delete 1 federated from A -> B
    b. reply/fav/boost of 1 from B -> A
  3. B's reply/fav/boost contains 1 embedded and signed, so we re-create 1 using the remote status content

The HTML is escaped because all "local" statuses have their HTML escaped, but we're creating it using the federated content, which is already HTML-formatted.

I think the root cause here is that we should never attempt to find_or_create local statuses when resolving them, only find them.

@nightpool nightpool added bug Something isn't working priority - medium labels Sep 23, 2017
@wxcafe wxcafe added api REST API, Streaming API, Web Push API work in progress Not to be merged, currently being worked on labels Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api REST API, Streaming API, Web Push API bug Something isn't working work in progress Not to be merged, currently being worked on
Projects
None yet
Development

No branches or pull requests

2 participants