Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen video on desktop Safari doesn't play fullscreen #5160

Open
nolanlawson opened this issue Sep 30, 2017 · 7 comments
Open

Fullscreen video on desktop Safari doesn't play fullscreen #5160

nolanlawson opened this issue Sep 30, 2017 · 7 comments

Comments

@nolanlawson
Copy link
Collaborator

@nolanlawson nolanlawson commented Sep 30, 2017

In desktop Safari 11.0 on Sierra, when you click the fullscreen button, the video doesn't go fullscreen. Instead it seems to get stuck in the column.

Seen on 1df453a. Related: #5159.

out2


  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
  • This bug happens on a tagged release and not on master (If you're a user, don't worry about this).
@nolanlawson

This comment has been minimized.

Copy link
Collaborator Author

@nolanlawson nolanlawson commented Sep 30, 2017

Same issue in Safari Technology Preview 11.1

@ghost

This comment has been minimized.

Copy link

@ghost ghost commented Oct 14, 2017

I confirme it.
out

@mkosler

This comment has been minimized.

Copy link

@mkosler mkosler commented Nov 7, 2017

Doesn't seem to only be on Safari. I'm on Chrome Version 61.0.3163.100 (Official Build) (64-bit) and am experience a similar issue. For me, if the video is in the home timeline column, it expands to the fullscreen correctly; however, if I select the toot and expand it from the context-sensitive right column, it expands like shown.

fullscreen-full-window

@nullkal

This comment has been minimized.

Copy link
Collaborator

@nullkal nullkal commented Nov 7, 2017

I found the problem in Safari and the one in Google Chrome is different: My PR (#5611) fixes the latter, but the former is not fixed.

Timeline column is rendered in /mastodon/components/scrollable_list.js and detailed status column is rendered in /mastodon/features/status/index.js respectively, but #5159 modifies only /mastodon/components/scrollable_list.js and this is the cause of the problem in Google Chrome.

Regarding the problem in Safari, I'm not 100% sure but I suspect Safari does not treat contain: none correctly.

@nullkal

This comment has been minimized.

Copy link
Collaborator

@nullkal nullkal commented Nov 7, 2017

Safari does not support CSS containment, so it doesn't related to the problem. https://caniuse.com/#feat=css-containment

@Gargron Gargron closed this in 864c4d8 Nov 7, 2017
@nullkal

This comment has been minimized.

Copy link
Collaborator

@nullkal nullkal commented Nov 7, 2017

864c4d8 fixes only what @mkosler pointed out, but the main issue is not resolved. So I reopen this issue.

@nullkal nullkal reopened this Nov 7, 2017
cobodo pushed a commit to cobodo/mastodon that referenced this issue Dec 6, 2017
 tootsuite#5160) (tootsuite#5611)

* Make fullscreen video in detailed status plays in fullscreen (Fix tootsuite#5160)

* Directly assign the initial state
@mthld

This comment has been minimized.

Copy link

@mthld mthld commented Sep 9, 2019

almost 2 years 🎂👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.