There is no hotkey for expanding a toot with a CW #5550

Closed
ilianaw opened this Issue Oct 28, 2017 · 10 comments

Comments

Projects
None yet
6 participants
@ilianaw

ilianaw commented Oct 28, 2017

Fully using Mastodon with a keyboard isn't quite usable without being able to expand a toot with a CW.

May I suggest shift+enter?

(I can hit Tab four times to focus the Show More button and hit space as a work around. That's certainly not ideal.)


  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
  • This bug happens on a tagged release and not on master (If you're a user, don't worry about this).
@claiire

This comment has been minimized.

Show comment
Hide comment
@claiire

claiire Nov 17, 2017

Tbh I really think this should be a higher priority thing.

Ensuring that a website is usable with the keyboard only is an important accessibility feature, and shortcuts aren't quite complete without an expand cw shortcut.

claiire commented Nov 17, 2017

Tbh I really think this should be a higher priority thing.

Ensuring that a website is usable with the keyboard only is an important accessibility feature, and shortcuts aren't quite complete without an expand cw shortcut.

@beatrix-bitrot

This comment has been minimized.

Show comment
Hide comment
@beatrix-bitrot

beatrix-bitrot Nov 17, 2017

Collaborator

how do you feel about space for this?

Collaborator

beatrix-bitrot commented Nov 17, 2017

how do you feel about space for this?

@sorin-davidoi

This comment has been minimized.

Show comment
Hide comment
@sorin-davidoi

sorin-davidoi Nov 17, 2017

Collaborator

It works with Enter when you focus the toggle button.

Collaborator

sorin-davidoi commented Nov 17, 2017

It works with Enter when you focus the toggle button.

@nightpool

This comment has been minimized.

Show comment
Hide comment
@nightpool

nightpool Nov 18, 2017

Collaborator
Collaborator

nightpool commented Nov 18, 2017

@ilianaw

This comment has been minimized.

Show comment
Hide comment
@ilianaw

ilianaw Nov 18, 2017

Hitting tab four times to focus toggle isn't good enough, frankly.

x would be reasonable to me.

I'd be happy with space but you can currently use that to scroll down a page, I think getting in the way of keys that currently do things is not a good idea.

ilianaw commented Nov 18, 2017

Hitting tab four times to focus toggle isn't good enough, frankly.

x would be reasonable to me.

I'd be happy with space but you can currently use that to scroll down a page, I think getting in the way of keys that currently do things is not a good idea.

@beatrix-bitrot

This comment has been minimized.

Show comment
Hide comment
@beatrix-bitrot

beatrix-bitrot Nov 18, 2017

Collaborator

x then, very well

Collaborator

beatrix-bitrot commented Nov 18, 2017

x then, very well

@marrus-sh marrus-sh referenced this issue in glitch-soc/mastodon Nov 27, 2017

Merged

Implement status hotkeys + spoiler expanding #232

@deutrino

This comment has been minimized.

Show comment
Hide comment
@deutrino

deutrino Jan 3, 2018

Is there anything standing in the way of merging this?

deutrino commented Jan 3, 2018

Is there anything standing in the way of merging this?

@sorin-davidoi

This comment has been minimized.

Show comment
Hide comment
@sorin-davidoi

sorin-davidoi Jan 3, 2018

Collaborator

There is nothing to merge yet, as no one opened a pull request fixing this.

Collaborator

sorin-davidoi commented Jan 3, 2018

There is nothing to merge yet, as no one opened a pull request fixing this.

@deutrino

This comment has been minimized.

Show comment
Hide comment
@deutrino

deutrino Jan 3, 2018

I meant from changes in glitch-soc/mastodon#232.

I can never get an answer from any of them about how changes might flow back upstream - I've asked regarding media previews, for example, and never gotten an answer.

deutrino commented Jan 3, 2018

I meant from changes in glitch-soc/mastodon#232.

I can never get an answer from any of them about how changes might flow back upstream - I've asked regarding media previews, for example, and never gotten an answer.

@beatrix-bitrot

This comment has been minimized.

Show comment
Hide comment
@beatrix-bitrot

beatrix-bitrot Jan 4, 2018

Collaborator

@deutrino sorry about not getting back to you. there's a lot of reasons things don't make it back upstream. some have, most don't. here i think the change in functionality depended on refactoring some stuff, and was also done on a set of files that don't actually exist upstream, so it can't be merged into upstream and it's also not trivial to backport it. everyone has things they'd rather be doing.

Collaborator

beatrix-bitrot commented Jan 4, 2018

@deutrino sorry about not getting back to you. there's a lot of reasons things don't make it back upstream. some have, most don't. here i think the change in functionality depended on refactoring some stuff, and was also done on a set of files that don't actually exist upstream, so it can't be merged into upstream and it's also not trivial to backport it. everyone has things they'd rather be doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment