New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX][Notifications] `Play sound` should be disabled when `Show in column` is disabled #5767

Closed
xuv opened this Issue Nov 21, 2017 · 2 comments

Comments

Projects
None yet
4 participants
@xuv
Contributor

xuv commented Nov 21, 2017

Here is a picture of the settings:
screen shot 2017-11-20 at 21 58 54

I believe that with all these settings turned off, the "Play Sound" is a little confusing.
In this example, all Favourites notifications have been turned off, but the "sound" is still playing when a post is being favourited. It's kind of funny to hear a notification but not seeing what it is about.

Maybe a better behavior would be: When Show in column is turned off, Play sound should be off also.


  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
  • This bug happens on a tagged release and not on master (If you're a user, don't worry about this).
@Cassolotl

This comment has been minimized.

Show comment
Hide comment
@Cassolotl

Cassolotl Nov 21, 2017

I went through a phase of having sound on but in-column off, because it was nice to know that people were interacting with my posts but I didn't care which posts or what they were doing! In the end I turned the bloops off because the pop-ups stopped working so I had no way to know when I was in another tab which bloops were replies that I could go see in-column.

You're right though, most people probably don't want to do what I did and this makes a lot of sense!

Cassolotl commented Nov 21, 2017

I went through a phase of having sound on but in-column off, because it was nice to know that people were interacting with my posts but I didn't care which posts or what they were doing! In the end I turned the bloops off because the pop-ups stopped working so I had no way to know when I was in another tab which bloops were replies that I could go see in-column.

You're right though, most people probably don't want to do what I did and this makes a lot of sense!

@Gargron

This comment has been minimized.

Show comment
Hide comment
@Gargron

Gargron May 26, 2018

Member

It feels like a little detail and as said above some people might wanna do it.

Member

Gargron commented May 26, 2018

It feels like a little detail and as said above some people might wanna do it.

@Gargron Gargron closed this May 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment