New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional protocols to URI schemes #6072

Closed
maiki opened this Issue Dec 19, 2017 · 15 comments

Comments

Projects
None yet
@maiki

maiki commented Dec 19, 2017

Posting this after a short discussion: please create links from gopher URLs.

SDF runs a prominent gopher server, and we share the URLs constantly, but none of them are links. We currently have http, https and ftp. It would help us if gopher were added. ^_^

Adding a request to add ftp and irc as well.

@crcx

This comment has been minimized.

Show comment
Hide comment
@crcx

crcx Dec 19, 2017

I'd like to see this as well.

crcx commented Dec 19, 2017

I'd like to see this as well.

@jamestomasino

This comment has been minimized.

Show comment
Hide comment
@jamestomasino

jamestomasino Dec 19, 2017

Easy and welcome addition

jamestomasino commented Dec 19, 2017

Easy and welcome addition

@algernon

This comment has been minimized.

Show comment
Hide comment
@algernon

algernon Dec 20, 2017

Contributor

For anyone interested, as far as I understand this is where the change would have to be made. Something like turning that https? into https?|gopher.

I have not tried it, mind you, and am not planning to (not going to touch twitter projects), but if anyone's up for it, I hope the above helps.

Might add ftp to that aswell, because that does not seem to be supported either (just tried on my own instance running 2.1).

Contributor

algernon commented Dec 20, 2017

For anyone interested, as far as I understand this is where the change would have to be made. Something like turning that https? into https?|gopher.

I have not tried it, mind you, and am not planning to (not going to touch twitter projects), but if anyone's up for it, I hope the above helps.

Might add ftp to that aswell, because that does not seem to be supported either (just tried on my own instance running 2.1).

@LeeteqXV

This comment has been minimized.

Show comment
Hide comment
@LeeteqXV

LeeteqXV Dec 20, 2017

A huge +1 for this.

LeeteqXV commented Dec 20, 2017

A huge +1 for this.

@maiki maiki changed the title from Add gopher to URI schemes to Add additional protocols to URI schemes Dec 20, 2017

@maiki

This comment has been minimized.

Show comment
Hide comment
@maiki

maiki Dec 20, 2017

@algernon, to clarify for my own knowledge, the Mastodon project pulls in that library to parse URLs? I don't know much about how it is built.

💐 for your thoughts. ^_^

maiki commented Dec 20, 2017

@algernon, to clarify for my own knowledge, the Mastodon project pulls in that library to parse URLs? I don't know much about how it is built.

💐 for your thoughts. ^_^

@nightpool

This comment has been minimized.

Show comment
Hide comment
@nightpool

nightpool Dec 20, 2017

Collaborator

yeah this would require some changes to https://github.com/twitter/twitter-text, which we use for URL extraction. Here are the relevant lines:

https://github.com/twitter/twitter-text/blob/master/rb/lib/twitter-text/regex.rb#L246-L257

Collaborator

nightpool commented Dec 20, 2017

yeah this would require some changes to https://github.com/twitter/twitter-text, which we use for URL extraction. Here are the relevant lines:

https://github.com/twitter/twitter-text/blob/master/rb/lib/twitter-text/regex.rb#L246-L257

@kensanata kensanata referenced this issue Dec 28, 2017

Closed

Parenthesis and URLs #6121

1 of 2 tasks complete

@nightpool nightpool referenced this issue Jan 12, 2018

Closed

Magnet URIs are not clickable #6248

1 of 2 tasks complete
@wakest

This comment has been minimized.

Show comment
Hide comment
@wakest

wakest Jan 13, 2018

Would be great to get dat:// URI support. I’ve already come across numerous people posting dat links that I had to manually copy and paste to access.

and maybe ipfs:// too, though it looks like they might still be trying to figure out some details of the implementation of how their URIs work. (ipfs/go-ipfs#1678)

wakest commented Jan 13, 2018

Would be great to get dat:// URI support. I’ve already come across numerous people posting dat links that I had to manually copy and paste to access.

and maybe ipfs:// too, though it looks like they might still be trying to figure out some details of the implementation of how their URIs work. (ipfs/go-ipfs#1678)

@maiki

This comment has been minimized.

Show comment
Hide comment
@maiki

maiki Jan 13, 2018

I think dat and ipfs would be great additions, but neither are listed on the IANA scheme list. In other news, I doubt we will be able to send any additional schemes upstream to Twitter.

These observations combined leas me to think we need to do two broad things:

  1. Create a replacement text parsing library
  2. Arbitrarily add schemes to it (like ipsf://), which means maintain a list

Thoughts? 😃

I am not trying to start a new project and recruit folks, just thinking about solving this particular problem. Brainstorm with me!

maiki commented Jan 13, 2018

I think dat and ipfs would be great additions, but neither are listed on the IANA scheme list. In other news, I doubt we will be able to send any additional schemes upstream to Twitter.

These observations combined leas me to think we need to do two broad things:

  1. Create a replacement text parsing library
  2. Arbitrarily add schemes to it (like ipsf://), which means maintain a list

Thoughts? 😃

I am not trying to start a new project and recruit folks, just thinking about solving this particular problem. Brainstorm with me!

@gemlog

This comment has been minimized.

Show comment
Hide comment
@gemlog

gemlog Jan 13, 2018

@maiki My first thought was how difficult is it to implement those URIs that frankly are not used much outside of a small community. I looked at the linked code in the twitter-text link and it looked fairly straight-forward (I was weirded out a bit 'coz my brain thot it was reading python and I don't know ruby..).
Then I thought of some (to me) fun URIs if we had authentication down solid.
To be truly painless to extend to new URIs cheaply it would have to be reworked though vs just adding cases? < update: duh, as maiki just indicated above...>

gemlog commented Jan 13, 2018

@maiki My first thought was how difficult is it to implement those URIs that frankly are not used much outside of a small community. I looked at the linked code in the twitter-text link and it looked fairly straight-forward (I was weirded out a bit 'coz my brain thot it was reading python and I don't know ruby..).
Then I thought of some (to me) fun URIs if we had authentication down solid.
To be truly painless to extend to new URIs cheaply it would have to be reworked though vs just adding cases? < update: duh, as maiki just indicated above...>

@virtadpt

This comment has been minimized.

Show comment
Hide comment
@virtadpt

virtadpt Jan 13, 2018

It would be nice to be able to click on a magnet URL and get some kind of response, too. Maybe a pop-up button to copy it automatically into the local clipboard, for pasting elsewhere?

virtadpt commented Jan 13, 2018

It would be nice to be able to click on a magnet URL and get some kind of response, too. Maybe a pop-up button to copy it automatically into the local clipboard, for pasting elsewhere?

@JamesHealdUK

This comment has been minimized.

Show comment
Hide comment
@JamesHealdUK

JamesHealdUK Jan 14, 2018

@virtadpt Actually, I could have sworn that you can open magnet links that have a "open with" dialogue, in Firefox at least iirc. That would be awesome!

But otherwise, definitely big +1 from me too.

JamesHealdUK commented Jan 14, 2018

@virtadpt Actually, I could have sworn that you can open magnet links that have a "open with" dialogue, in Firefox at least iirc. That would be awesome!

But otherwise, definitely big +1 from me too.

@rysiekpl

This comment has been minimized.

Show comment
Hide comment
@rysiekpl

rysiekpl Jan 14, 2018

Contributor

+1 on magnet://, gopher://, ipfs://, irc://.

Really not convinced about ftp:// though. This terrible Frankenstein of a protocol should have died a long time ago. May I suggest sftp:// instead?

Contributor

rysiekpl commented Jan 14, 2018

+1 on magnet://, gopher://, ipfs://, irc://.

Really not convinced about ftp:// though. This terrible Frankenstein of a protocol should have died a long time ago. May I suggest sftp:// instead?

@cheesegrits

This comment has been minimized.

Show comment
Hide comment
@cheesegrits

cheesegrits Jan 14, 2018

+1 on more extensible URI handling.

cheesegrits commented Jan 14, 2018

+1 on more extensible URI handling.

Gargron added a commit that referenced this issue Jun 15, 2018

Gargron added a commit that referenced this issue Jun 15, 2018

Add dat, dweb, ipfs, ipns, ssb, gopher protocols to URL extractor (#7810
)

* Add dat:// and gopher:// to URL extractor

Fix #6072

* Fix comment indent

* Add dweb, ipfs, ipns, ssb
@wakest

This comment has been minimized.

Show comment
Hide comment
@wakest

wakest Jun 26, 2018

wait does #7810 mean you implemented this?!

wakest commented Jun 26, 2018

wait does #7810 mean you implemented this?!

@nightpool

This comment has been minimized.

Show comment
Hide comment
@nightpool

nightpool Jun 26, 2018

Collaborator

"Add dat, dweb, ipfs, ipns, ssb, gopher protocols to URL extractor"

Collaborator

nightpool commented Jun 26, 2018

"Add dat, dweb, ipfs, ipns, ssb, gopher protocols to URL extractor"

lawremipsum added a commit to lawremipsum/mspsocial-mastodon that referenced this issue Jul 7, 2018

Add dat, dweb, ipfs, ipns, ssb, gopher protocols to URL extractor (to…
…otsuite#7810)

* Add dat:// and gopher:// to URL extractor

Fix tootsuite#6072

* Fix comment indent

* Add dweb, ipfs, ipns, ssb

byronhulcher added a commit to byronhulcher/mastodon that referenced this issue Aug 18, 2018

Add dat, dweb, ipfs, ipns, ssb, gopher protocols to URL extractor (to…
…otsuite#7810)

* Add dat:// and gopher:// to URL extractor

Fix tootsuite#6072

* Fix comment indent

* Add dweb, ipfs, ipns, ssb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment