Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd additional protocols to URI schemes #6072
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
crcx
commented
Dec 19, 2017
|
I'd like to see this as well. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jamestomasino
commented
Dec 19, 2017
|
Easy and welcome addition |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
algernon
Dec 20, 2017
Contributor
For anyone interested, as far as I understand this is where the change would have to be made. Something like turning that https? into https?|gopher.
I have not tried it, mind you, and am not planning to (not going to touch twitter projects), but if anyone's up for it, I hope the above helps.
Might add ftp to that aswell, because that does not seem to be supported either (just tried on my own instance running 2.1).
|
For anyone interested, as far as I understand this is where the change would have to be made. Something like turning that I have not tried it, mind you, and am not planning to (not going to touch twitter projects), but if anyone's up for it, I hope the above helps. Might add |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
LeeteqXV
commented
Dec 20, 2017
|
A huge +1 for this. |
maiki
changed the title from
Add gopher to URI schemes
to
Add additional protocols to URI schemes
Dec 20, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
maiki
Dec 20, 2017
@algernon, to clarify for my own knowledge, the Mastodon project pulls in that library to parse URLs? I don't know much about how it is built.
maiki
commented
Dec 20, 2017
|
@algernon, to clarify for my own knowledge, the Mastodon project pulls in that library to parse URLs? I don't know much about how it is built. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
nightpool
Dec 20, 2017
Collaborator
yeah this would require some changes to https://github.com/twitter/twitter-text, which we use for URL extraction. Here are the relevant lines:
https://github.com/twitter/twitter-text/blob/master/rb/lib/twitter-text/regex.rb#L246-L257
|
yeah this would require some changes to https://github.com/twitter/twitter-text, which we use for URL extraction. Here are the relevant lines: https://github.com/twitter/twitter-text/blob/master/rb/lib/twitter-text/regex.rb#L246-L257 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
wakest
Jan 13, 2018
Would be great to get dat:// URI support. I’ve already come across numerous people posting dat links that I had to manually copy and paste to access.
and maybe ipfs:// too, though it looks like they might still be trying to figure out some details of the implementation of how their URIs work. (ipfs/go-ipfs#1678)
wakest
commented
Jan 13, 2018
|
Would be great to get dat:// URI support. I’ve already come across numerous people posting dat links that I had to manually copy and paste to access. and maybe ipfs:// too, though it looks like they might still be trying to figure out some details of the implementation of how their URIs work. (ipfs/go-ipfs#1678) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
maiki
Jan 13, 2018
I think dat and ipfs would be great additions, but neither are listed on the IANA scheme list. In other news, I doubt we will be able to send any additional schemes upstream to Twitter.
These observations combined leas me to think we need to do two broad things:
- Create a replacement text parsing library
- Arbitrarily add schemes to it (like
ipsf://), which means maintain a list
Thoughts?
I am not trying to start a new project and recruit folks, just thinking about solving this particular problem. Brainstorm with me!
maiki
commented
Jan 13, 2018
|
I think These observations combined leas me to think we need to do two broad things:
Thoughts? I am not trying to start a new project and recruit folks, just thinking about solving this particular problem. Brainstorm with me! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
gemlog
Jan 13, 2018
@maiki My first thought was how difficult is it to implement those URIs that frankly are not used much outside of a small community. I looked at the linked code in the twitter-text link and it looked fairly straight-forward (I was weirded out a bit 'coz my brain thot it was reading python and I don't know ruby..).
Then I thought of some (to me) fun URIs if we had authentication down solid.
To be truly painless to extend to new URIs cheaply it would have to be reworked though vs just adding cases? < update: duh, as maiki just indicated above...>
gemlog
commented
Jan 13, 2018
•
|
@maiki My first thought was how difficult is it to implement those URIs that frankly are not used much outside of a small community. I looked at the linked code in the twitter-text link and it looked fairly straight-forward (I was weirded out a bit 'coz my brain thot it was reading python and I don't know ruby..). |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
virtadpt
Jan 13, 2018
It would be nice to be able to click on a magnet URL and get some kind of response, too. Maybe a pop-up button to copy it automatically into the local clipboard, for pasting elsewhere?
virtadpt
commented
Jan 13, 2018
|
It would be nice to be able to click on a magnet URL and get some kind of response, too. Maybe a pop-up button to copy it automatically into the local clipboard, for pasting elsewhere? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
JamesHealdUK
Jan 14, 2018
@virtadpt Actually, I could have sworn that you can open magnet links that have a "open with" dialogue, in Firefox at least iirc. That would be awesome!
But otherwise, definitely big +1 from me too.
JamesHealdUK
commented
Jan 14, 2018
|
@virtadpt Actually, I could have sworn that you can open magnet links that have a "open with" dialogue, in Firefox at least iirc. That would be awesome! But otherwise, definitely big +1 from me too. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
rysiekpl
Jan 14, 2018
Contributor
+1 on magnet://, gopher://, ipfs://, irc://.
Really not convinced about ftp:// though. This terrible Frankenstein of a protocol should have died a long time ago. May I suggest sftp:// instead?
|
+1 on Really not convinced about |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
cheesegrits
commented
Jan 14, 2018
|
+1 on more extensible URI handling. |
kit-ty-kate
referenced this issue
in stom79/mastalab
Feb 17, 2018
Open
ftp:// urls are not recognized #326
added a commit
that referenced
this issue
Jun 15, 2018
Gargron
referenced this issue
Jun 15, 2018
Merged
Add dat, dweb, ipfs, ipns, ssb, gopher protocols to URL extractor #7810
Gargron
closed this
in
#7810
Jun 15, 2018
added a commit
that referenced
this issue
Jun 15, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
wakest
commented
Jun 26, 2018
|
wait does #7810 mean you implemented this?! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
nightpool
Jun 26, 2018
Collaborator
"Add dat, dweb, ipfs, ipns, ssb, gopher protocols to URL extractor"
|
"Add dat, dweb, ipfs, ipns, ssb, gopher protocols to URL extractor" |
maiki commentedDec 19, 2017
•
edited
Edited 1 time
-
maiki
edited Dec 20, 2017 (most recent)
Posting this after a short discussion: please create links from gopher URLs.
SDF runs a prominent gopher server, and we share the URLs constantly, but none of them are links. We currently have
http,httpsand. It would help us ifftpgopherwere added. ^_^Adding a request to add
ftpandircas well.