New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join several hashtags in a search/column #6359

Closed
renatolond opened this Issue Jan 25, 2018 · 20 comments

Comments

Projects
None yet
@renatolond
Collaborator

renatolond commented Jan 25, 2018

I noticed that there's multiple tags in which people add which songs they are listening to (np, nowplaying, radiotoot, tootradio, pouetradio, etc). I'd like to follow those hashtags for idea on what to listen, but for now the only way I found is to open a column for each of them and them have toots that use multiple of those appearing on several columns. I would like to be able to follow all of them in a single column.


  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
  • This bug happens on a tagged release and not on master (If you're a user, don't worry about this).
@Letiteuf55

This comment has been minimized.

Letiteuf55 commented Jan 29, 2018

Yeah, i need that too, i'm running out of space on my screen with all my # researches !

@Granitosaurus

This comment has been minimized.

Granitosaurus commented Apr 5, 2018

This is a huge issue for me as well as my 13" laptops screenspace is rather limited.

I also proposed another feature to address the same screenspace issue: #7050
Combination of both of these features would greatly improve user experience and screen-space effiency.

@Gargron

This comment has been minimized.

Member

Gargron commented Apr 5, 2018

Are we talking about OR, AND, or both?

@renatolond

This comment has been minimized.

Collaborator

renatolond commented Apr 5, 2018

I'm talking about OR. I would like to see posts that contain either np, nowPlaying, radioToot or tootRadio at the same column

@nightpool

This comment has been minimized.

Collaborator

nightpool commented Apr 5, 2018

@woj-tek

This comment has been minimized.

woj-tek commented Aug 2, 2018

Could I suggest making operator optional (defaulting to OR for example, though for me AND would be more natural)?
For example I would be quite often interested in narrowing search more instead of expanding them.

@roipoussiere

This comment has been minimized.

roipoussiere commented Aug 17, 2018

Just to resume the discussion, the behavior could be:

  • #nowplaying #radiotoot -> one of these hashtags
  • #nowplaying or #radiotoot -> one of these hashtags
  • #cute and #cat -> both of them

@wottpal wottpal referenced this issue Aug 19, 2018

Open

option to follow hashtags #1096

1 of 1 task complete
@gdpelican

This comment has been minimized.

Collaborator

gdpelican commented Sep 13, 2018

I'm thinking to have a look at this over the next wee while.

Apologies for the extremely rough mockup with hasty copy, but I was thinking something along the lines of this:

  • Perform a search, and add a new hashtag column to your desktop
  • Open the settings for that hashtag column
  • Add the option to specify additional hashtags to include in this column
  • Add the option to specify whether this is an 'AND' or an 'OR' relationship

captura de pantalla 2018-09-13 a la s 3 49 14 p m

Thoughts?

@fhemberger

This comment has been minimized.

Contributor

fhemberger commented Sep 14, 2018

I think it would be nice to have AND, OR and NOT operators, e.g.

  • #mastoart OR #creativetoots NOT #photography
  • #mastoart #creativetoots -#photography (as short form, defaulting to OR)
@joreg

This comment has been minimized.

joreg commented Oct 9, 2018

@gdpelican thanks for working on this!
thoughts:

  • when following multiple hashtags, the title should probably reflect that. ie. in your mockup you're following two hashtags, but the title only mentions one. maybe as soon as a column follows more than one hashtag, just title it "Hashtags"?
  • the description "Display toots with all of these hashtags" sounds a bit ambiguous to me and could better reflect the ANDiness it means, like eg: "Show only toots including all these hashtags"
  • while i actually think that OR is the most important usecase, instead of just one checkbox to decide between AND and OR, what would be amazing is to support something, like: (#programming || #coding) && !#javascript
@gdpelican

This comment has been minimized.

Collaborator

gdpelican commented Oct 9, 2018

Hi @joreg , I've actually made a PR which addresses most of concerns already, have a peek at
#8904

@joreg

This comment has been minimized.

joreg commented Oct 9, 2018

@gdpelican too good to be true!

@Cassolotl

This comment has been minimized.

Cassolotl commented Nov 30, 2018

Oh this was introduced now so this issue can probably be closed?

@Gargron Gargron closed this Nov 30, 2018

@ChameleonScales

This comment has been minimized.

ChameleonScales commented Dec 3, 2018

I don't see it implemented. Is it for the next release?

@Cassolotl

This comment has been minimized.

Cassolotl commented Dec 4, 2018

If it's not on your instance yet, you probably need to wait for your instance to be updated. What's your instance URL?

@ChameleonScales

This comment has been minimized.

ChameleonScales commented Dec 4, 2018

My instance is up to date (2.6.5). It's mamot.fr if you must know

@Cassolotl

This comment has been minimized.

Cassolotl commented Dec 4, 2018

And when you pin a hashtag search, you don't see this?:

screenshot 2018-12-04 at 19 08 17

Edit: I signed up on mamot.fr to investigate, and yeah, it's not there even when you pin it:

screenshot 2018-12-04 at 19 14 18

But I can't find the join-hashtags-in-search-results reference in the release notes. The merged pull request is #8904, which hasn't been rolled back. So I guess you need to talk to your admin?

@renatolond

This comment has been minimized.

Collaborator

renatolond commented Dec 4, 2018

I don't think it's out yet, I think it's coming on 2.7 🤔

@Gargron

This comment has been minimized.

Member

Gargron commented Dec 4, 2018

It's not in any releases yet

@Cassolotl

This comment has been minimized.

Cassolotl commented Dec 4, 2018

Ahhhh I see, and Glitch just gets it early. Cool. :) Thanks for clearing that up, knowledgeable people!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment