Hashtags in content warnings don't work #699

Closed
nevillepark opened this Issue Mar 30, 2017 · 8 comments

Comments

Projects
None yet
6 participants
@nevillepark
Contributor

nevillepark commented Mar 30, 2017

Currently, hashtags in the content warning field just behave like plain text. Here's an example.

This is inconvenient if, for example, a user wants to hide their #introductions post behind a content warning, but wants other users to be able to find other #introductions posts by clicking on the hashtag. It also prevents the effective use of hashtags for things some people may want to filter out and others may want to follow, like #food or #discourse.

screenshot from 2017-03-30 16-01-55

@ProgVal

This comment has been minimized.

Show comment
Hide comment
@ProgVal

ProgVal Apr 3, 2017

Contributor

If a hashtag is in the content of a toot, it appears in the search even if the toot has a content warning.
So I don't think it's an issue.

Contributor

ProgVal commented Apr 3, 2017

If a hashtag is in the content of a toot, it appears in the search even if the toot has a content warning.
So I don't think it's an issue.

@nevillepark

This comment has been minimized.

Show comment
Hide comment
@nevillepark

nevillepark Apr 4, 2017

Contributor

Sorry, this is what I mean: https://mastodon.social/@nev/1529407

If the hashtag is in the content warning, it isn't clickable and it doesn't appear in search results.

Contributor

nevillepark commented Apr 4, 2017

Sorry, this is what I mean: https://mastodon.social/@nev/1529407

If the hashtag is in the content warning, it isn't clickable and it doesn't appear in search results.

@ProgVal

This comment has been minimized.

Show comment
Hide comment
@ProgVal

ProgVal Apr 4, 2017

Contributor

Indeed, I misunderstood.

However, since content warnings are not displayed on non-mastodon instances, allowing tags there would create a gap between mastodon and the rest

Contributor

ProgVal commented Apr 4, 2017

Indeed, I misunderstood.

However, since content warnings are not displayed on non-mastodon instances, allowing tags there would create a gap between mastodon and the rest

@skddc

This comment has been minimized.

Show comment
Hide comment
@skddc

skddc Apr 22, 2017

However, since content warnings are not displayed on non-mastodon instances, allowing tags there would create a gap between mastodon and the rest

Maybe that's a good thing. If it works and is being used and liked by users, then it could make adding it to the underlying protocols and getting it adopted by other implementations a bit easier. If it's already outside of specs, then we might as well improve the feature based on user feedback and needs. No?

skddc commented Apr 22, 2017

However, since content warnings are not displayed on non-mastodon instances, allowing tags there would create a gap between mastodon and the rest

Maybe that's a good thing. If it works and is being used and liked by users, then it could make adding it to the underlying protocols and getting it adopted by other implementations a bit easier. If it's already outside of specs, then we might as well improve the feature based on user feedback and needs. No?

@nevillepark

This comment has been minimized.

Show comment
Hide comment
@nevillepark

nevillepark Apr 23, 2017

Contributor

Hmm. I wonder if there is a way to maintain the CW functionality on Mastodon, but degrade gracefully for non-Mastodon instances, in the Atom feed, etc. E. g. CW: {cw field} | {status}.

Contributor

nevillepark commented Apr 23, 2017

Hmm. I wonder if there is a way to maintain the CW functionality on Mastodon, but degrade gracefully for non-Mastodon instances, in the Atom feed, etc. E. g. CW: {cw field} | {status}.

rtucker added a commit to vulpineclub/mastodon that referenced this issue May 1, 2017

Gargron added a commit that referenced this issue May 10, 2017

Handle hashtags in spoiler_texts (partial fix for #699) (#2683)
* services: scan spoiler_text for hashtags (#699)

* views: link hashtags from spoiler_texts

This covers linking hashtags from within the spoiler
text on the server-generated pages.

* services: fix string concat going into hashtag RE

Cleaner Ruby syntax, may handle immutable strings better

beatrix-bitrot added a commit that referenced this issue May 12, 2017

beatrix-bitrot added a commit that referenced this issue May 13, 2017

Gargron added a commit that referenced this issue May 13, 2017

Revert HTML CW changes (#3020)
* selectively Revert "Fix regressions from #2683 (#2970)"

This reverts commit 72698bc.

* Revert "Handle hashtags in spoiler_texts (partial fix for #699) (#2683)"

This reverts commit e249168.

@ghost ghost referenced this issue May 25, 2017

Closed

CW should include the image, too #1010

2 of 2 tasks complete
@Gargron

This comment has been minimized.

Show comment
Hide comment
@Gargron

Gargron Jun 29, 2017

Member

We have attempted to make content warnings contain rich text, including mentions, links and hashtags. However, this meant that content warnings could not be copied into new toots automatically any longer. It is simpler to think of them as a plain text label on top of the actual content.

Member

Gargron commented Jun 29, 2017

We have attempted to make content warnings contain rich text, including mentions, links and hashtags. However, this meant that content warnings could not be copied into new toots automatically any longer. It is simpler to think of them as a plain text label on top of the actual content.

@sparr

This comment has been minimized.

Show comment
Hide comment
@sparr

sparr Oct 25, 2017

@Gargron "this meant that content warnings could not be copied into new toots automatically any longer"

why not?

sparr commented Oct 25, 2017

@Gargron "this meant that content warnings could not be copied into new toots automatically any longer"

why not?

@sparr

This comment has been minimized.

Show comment
Hide comment
@sparr

sparr Oct 25, 2017

@ProgVal why aren't content warnings displayed on non-mastodon instances? Can they not just be included at the top of the post?

sparr commented Oct 25, 2017

@ProgVal why aren't content warnings displayed on non-mastodon instances? Can they not just be included at the top of the post?

abcang added a commit to pixiv/mastodon that referenced this issue Nov 27, 2017

@nightpool nightpool referenced this issue Jan 19, 2018

Closed

[Feature] Allow #hastags in CW's warnings #6296

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment