New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidekiq full of duplicate SynchronizeFeaturedCollectionWorker jobs #7041

Closed
nolanlawson opened this Issue Apr 4, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@nolanlawson
Copy link
Collaborator

nolanlawson commented Apr 4, 2018

#7019 fixed the issues with defederation (Sidekiq full of ~170k jobs, most failing), but after applying the patch, Sidekiq constantly has ~10 busy jobs doing SynchronizeFeaturedCollectionWorker for the same account ID. When one completes, it seems to just start another one:

screenshot 2018-04-04 08 48 36

I checked the account in question, and it's a remote account that posts fairly frequently (once every few minutes) and has two pinned toots. Oddly when the account is viewed on toot.cafe, only one pinned toot is shown.

Right now the impact is just that Sidekiq is always uselessly busy, but I'm worried this could cause problems if the user in question starts posting more frequently, or if this points to deeper issues, etc.

Mastodon 2.3.3, Ruby 2.4.2 w/ jemalloc, Ubuntu 16.10.


  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
  • This bug happens on a tagged release and not on master (If you're a user, don't worry about this).

@nolanlawson nolanlawson added the bug label Apr 4, 2018

Gargron added a commit that referenced this issue Apr 4, 2018

Gargron added a commit that referenced this issue Apr 12, 2018

Ensure SynchronizeFeaturedCollectionWorker is unique and clean up (#7043
)

* Ensure SynchronizeFeaturedCollectionWorker is unique and clean up

Fix #7041

* Fix code style issue
@nolanlawson

This comment has been minimized.

Copy link
Collaborator

nolanlawson commented Apr 14, 2018

FWIW this problem seems to have naturally fixed itself after a few days. I'm still on my patched version of 2.3.3 BTW (see below). Glad to know you came up with a better solution though 👍.

screenshot 2018-04-14 14 43 59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment