Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the alternate text field its own modal window #8320

Closed
Sylvhem opened this issue Aug 20, 2018 · 2 comments

Comments

@Sylvhem
Copy link
Contributor

commented Aug 20, 2018

Currently, after having uploaded a media file, users have the possibility to add an alternative text to it.
Sadly, there is, in my opinions, three problems with the current implementation:

  1. The field used for the input is really small, which make it difficult to use.
  2. The field isn't a true field text, and spell checking isn't available as a result.
  3. When you click outside the field and then go back to it, the cursor isn't positioned at the end but at the begging of the text. This is both quite annoying and impractical.

I would suggest that, instead of having the field right on the image, we use an icon and a small snippet of text (something like "Add alternate text") that, when clicked, open a modal containing the image and a proper text field. In that way, it would be similar to the "Crop" function we already have.
I think something along the lines of Twitter's implementation of this feature (see below) is what we should aim at.

Twitter's image description modal window.


  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
@ThibG

This comment has been minimized.

Copy link
Collaborator

commented Aug 20, 2018

Kind of a duplicate of #6868 and #6713. I tried to do that this week-end by reusing the ImageLoader (and other components for other types of media) but it was much harder than anticipated, as ImageLoader is quite a pile of HTML and CSS hacks and adding anything to it turns out to be tricky.

@Sylvhem

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2018

Oh sorry, I didn't found those while browsing the opened issues. I guess this one should be closed?

@Gargron Gargron added the suggestion label Oct 20, 2018

Gargron added a commit that referenced this issue Aug 14, 2019

Add media editing modal
Move media description input to a modal and unite that modal with
the focal point modal. Add a hint about choosing focal points, as
well as a preview of a 16:9 thumbnail. Enable the user to watch
the video next to the media description input.

Fix #8320
Fix #6713

Gargron added a commit that referenced this issue Aug 14, 2019

Add media editing modal
Move media description input to a modal and unite that modal with
the focal point modal. Add a hint about choosing focal points, as
well as a preview of a 16:9 thumbnail. Enable the user to watch
the video next to the media description input.

Fix #8320
Fix #6713

Gargron added a commit that referenced this issue Aug 14, 2019

Add media editing modal (#11563)
Move media description input to a modal and unite that modal with
the focal point modal. Add a hint about choosing focal points, as
well as a preview of a 16:9 thumbnail. Enable the user to watch
the video next to the media description input.

Fix #8320
Fix #6713
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.