Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't focus spiler input when disabled spoiler #10017

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
3 participants
@hinaloe
Copy link
Contributor

hinaloe commented Feb 12, 2019

When disabled CW, user can focus spiler-input with Shift+Tab. (since #7508?)
This PR prevent it.

@Gargron Gargron merged commit 0e513ff into tootsuite:master Feb 12, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@hinaloe hinaloe deleted the hinaloe:fix/dont-focus-spoiler branch Feb 12, 2019

@ThibG

This comment has been minimized.

Copy link
Collaborator

ThibG commented Feb 12, 2019

Wouldn't setting disabled be better?

@Gargron

This comment has been minimized.

Copy link
Member

Gargron commented Feb 12, 2019

Okay, that would be a cleaner solution (maybe? You can't tab-focus disabled input fields, can you?) but I think behaviour-wise there is no difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.