Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve image description user experience #10036

Merged
merged 3 commits into from Feb 14, 2019

Conversation

Projects
None yet
3 participants
@BenLubar
Copy link
Contributor

BenLubar commented Feb 13, 2019

  • Add image descriptions to searchable post content.
  • Allow multi-line image descriptions.

BenLubar added some commits Feb 13, 2019

@BenLubar BenLubar force-pushed the BenLubar-PR:image-description-ux branch from bf74756 to 7a76d58 Feb 13, 2019

BenLubar added a commit to BenLubar-PR/mastodon that referenced this pull request Feb 13, 2019

BenLubar added a commit to BenLubar-PR/mastodon that referenced this pull request Feb 13, 2019

@Cassolotl

This comment has been minimized.

Copy link

Cassolotl commented Feb 13, 2019

This sounds great! Could we see a screenshot please, since it's an accessibility UI thing?

@Gargron

This comment has been minimized.

Copy link
Member

Gargron commented Feb 14, 2019

There are no visual changes as far as I can tell

@Gargron Gargron merged commit 309043b into tootsuite:master Feb 14, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

Gargron added a commit that referenced this pull request Feb 17, 2019

Improve image description user experience (#10036)
* Add image descriptions to searchable post content.

* Allow multi-line image descriptions.

* Request image descriptions in the same query as posts when creating the search index.

(see #10036 (comment))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.