Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Announce activities of unknown statuses not fetching those statuses #10065

Merged
merged 1 commit into from Feb 17, 2019

Conversation

Projects
None yet
2 participants
@Gargron
Copy link
Member

Gargron commented Feb 17, 2019

Regression from #9998

@Gargron Gargron force-pushed the fix-announce-regression branch from 5e63384 to 9102442 Feb 17, 2019

@Gargron Gargron force-pushed the fix-announce-regression branch from 9102442 to 5946d9d Feb 17, 2019

@ThibG

ThibG approved these changes Feb 17, 2019

Copy link
Collaborator

ThibG left a comment

Why did I do that… the comment even disagreed with the code =_=
Sorry about that. This fix looks good to me.

@Gargron Gargron merged commit 1a1b817 into master Feb 17, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@ykzts ykzts deleted the fix-announce-regression branch Feb 17, 2019

Gargron added a commit that referenced this pull request Feb 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.