Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow getting-started to scroll on short screens #10075

Merged
merged 1 commit into from Feb 27, 2019

Conversation

Projects
None yet
3 participants
@trwnh
Copy link
Contributor

trwnh commented Feb 18, 2019

At 480px height, there is not enough space to fully display the footer.

Before After
firefox_2019-02-18_10-39-57 firefox_2019-02-18_10-40-29
Allow getting-started to scroll on short screens
At 480px height, there is not enough space to fully display the footer.
@ThibG

ThibG approved these changes Feb 18, 2019

@trwnh

This comment has been minimized.

Copy link
Contributor Author

trwnh commented Feb 27, 2019

can this be merged? @Gargron

@Gargron Gargron merged commit df01206 into tootsuite:master Feb 27, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

Gargron added a commit that referenced this pull request Mar 5, 2019

Allow getting-started to scroll on short screens (#10075)
At 480px height, there is not enough space to fully display the footer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.