Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd tooltips to Clear & Settings buttons #1021
Conversation
JanCVanB
and others
added some commits
Apr 6, 2017
yiskah
approved these changes
Apr 8, 2017
Looks good to me. I think someone else should check this too though
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
Gargron
Apr 8, 2017
Member
I believe this has been already done in #1101 with localizations, sorry! Thank you for your effort. The only thing the other PR was missing was aria-label, so if you wanna reopen your PR just to add those, you are welcome to!
|
I believe this has been already done in #1101 with localizations, sorry! Thank you for your effort. The only thing the other PR was missing was |
Gargron
closed this
Apr 8, 2017
added a commit
to pixiv/mastodon
that referenced
this pull request
Apr 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
JanCVanB commentedApr 6, 2017
Add the same type of HTML
titles (andaria-labels) as on other icon buttons.