Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clearer error when/if gpg fails #10228

Merged
merged 1 commit into from Mar 10, 2019

Conversation

Projects
None yet
3 participants
@armandfardeau
Copy link
Contributor

armandfardeau commented Mar 10, 2019

When attempting to use Mastodon via Vagrant for development, the following line failed:

gpg --keyserver hkp://keys.gnupg.net --recv-keys 409B6B1796C275462A1703113804BB82D39DC0E3
(This happens sometimes because keys.gnupg.net occasionally times out, or so I gather; when I ran the command manually it worked fine.)

This prevented RVM from installing and naturally meant that any of the following steps which required ruby didn't work.

However, there was no clear indication that this was the problem, making it somewhat difficult to debug. If RVM fails to install, the provisioning script should terminate immediately and notify the user to probably just try again.

This P.R. solve this issue : #7226

Vagrant exits when script failed after retrying one time:
Capture d’écran 2019-03-10 à 12 52 58
And when it succeed it does nothing special:
Capture d’écran 2019-03-10 à 13 03 12

@ykzts

ykzts approved these changes Mar 10, 2019

@Gargron Gargron merged commit b6bc98c into tootsuite:master Mar 10, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.