Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix poll update handler calling method was that was not available #10246

Merged
merged 5 commits into from Mar 12, 2019

Conversation

@Gargron
Copy link
Member

commented Mar 12, 2019

Fix #10241

@ThibG
ThibG approved these changes Mar 12, 2019
@Gargron

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2019

@ThibG I have not found the source for the DeliveryWorker problem yet 😕

@ThibG

This comment has been minimized.

Copy link
Collaborator

commented Mar 12, 2019

@Gargron me neither

@ThibG
Copy link
Collaborator

left a comment

I think you overlooked something (inline comment).
Otherwise LGTM.

app/lib/activitypub/activity/update.rb Outdated Show resolved Hide resolved
app/services/vote_service.rb Outdated Show resolved Hide resolved
@ThibG
ThibG approved these changes Mar 12, 2019

@Gargron Gargron merged commit 9f5b55a into master Mar 12, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@Gargron Gargron deleted the fix-poll-update-handler branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.