Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admission-based registrations mode #10250

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
2 participants
@Gargron
Copy link
Member

Gargron commented Mar 13, 2019

Fix #6856
Fix #6951


Between open registrations, and closed registrations, admission-based registrations mode allows servers to accept new users in a manually controlled manner. To the outside viewer, there are no practical differences between open and admission-based registrations, as both the sign up API and the sign up form remain available. However, "Sign up" on the form changes to "Request an invite".

Accounts created when admission-based mode is active cannot be logged into or used via API tokens.

After requesting an invite, the user receives a confirmation e-mail as usual. It is communicated in the message that the account won't be available straight away, but that it is instead pending review.

Once the e-mail is confirmed, the staff receives an e-mail about a new pending account. They can then approve or reject the user's application. Rejection removes the user's record and frees up the username. Approval, on the other hand, unlocks the new account and sends the user the welcome e-mail.

Note: Because registrations_mode is technically a new setting, if you had previously closed registrations, you will need to close them again after this update! However, since admission-based mode is safe for all intents and purposes, it should be a better new choice than simply closing registrations in most cases.


  • Change database schema
  • Change admin setting for registrations
  • Change user-facing strings about registrations
  • Change tootctl for open/close commands
  • Add UI for viewing and approving pending registrations
  • Add e-mail notifications about pending registrations
  • Change confirmation e-mail to mention pending review

@Gargron Gargron force-pushed the feature-approval branch 9 times, most recently from 8f526fd to 2ffe4b3 Mar 13, 2019

@Gargron Gargron changed the title Approval-based registrations mode Admission-based registrations mode Mar 13, 2019

@Gargron Gargron force-pushed the feature-approval branch from 2ffe4b3 to 35a7a17 Mar 14, 2019

@Gargron Gargron marked this pull request as ready for review Mar 14, 2019

@Gargron Gargron force-pushed the feature-approval branch from 35a7a17 to fe5f58a Mar 14, 2019

@ykzts

ykzts approved these changes Mar 14, 2019

@Gargron Gargron merged commit 51e154f into master Mar 14, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@Gargron Gargron deleted the feature-approval branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.