Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to silence or lower the volume of the notification sound #10473

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@lfuelling
Copy link
Contributor

commented Apr 4, 2019

This PR adds the ability to either silence or lower the volume of the notification sound. It's implemented by adding two new checkboxes to Settings > Notifications.

screenshot of the new checkboxes

The defaults are as before:

  • lower volume: false
  • sound activated: true

@lfuelling lfuelling force-pushed the lfuelling:master branch from 9297d65 to 4c53868 Apr 4, 2019

@Gargron

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

The notifications sound is specific to the notifications column and can be disabled through those column's settings. Admittedly it doesn't allow you to lower its volume, but I am not sure that warrants adding two options on a separate page.

@lfuelling

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

I didn't even know that the columns have their own settings.

IMO Settings > Notifications would be the perfect place for those as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.