Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor performance improvements and cleanup in formatter #10765

Merged
merged 1 commit into from May 15, 2019

Conversation

Projects
None yet
2 participants
@ThibG
Copy link
Collaborator

commented May 14, 2019

The whole rendering process of an already-loaded 460-char toot is sped up by a bit over 10%.

Removing the escaping part of utf8_friendly_extractor altogether cuts the remaining rendering time almost in half.

@ThibG ThibG force-pushed the ThibG:fixes/formatter-performance-fixes branch 3 times, most recently from 8d5ef47 to c131603 May 14, 2019

@ThibG ThibG force-pushed the ThibG:fixes/formatter-performance-fixes branch from c131603 to eec6cd0 May 14, 2019

@Gargron Gargron merged commit c1c8c7b into tootsuite:master May 15, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.