Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds click-able div that expands status (#10733) #10766

Merged
merged 1 commit into from May 15, 2019

Conversation

Projects
None yet
2 participants
@Dar13
Copy link
Contributor

commented May 15, 2019

The clickable div is positioned under the account avatar and covers all empty space below it to the end of the status as shown in the image below.

image

This is an alternate implementation to the one implemented in #9492, as suggested in #10733 and in the comments of #8529.

@Dar13 Dar13 force-pushed the Dar13:issue_10733 branch from 4006bf1 to 142eef8 May 15, 2019

Adds click-able div that expands status (#10733)
The clickable div is positioned under the account avatar and covers
all empty space below it to the end of the status.

@Dar13 Dar13 force-pushed the Dar13:issue_10733 branch from 142eef8 to bcafa55 May 15, 2019

@Gargron Gargron merged commit 4ab094d into tootsuite:master May 15, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

Gargron added a commit that referenced this pull request May 19, 2019

Adds click-able div that expands status (#10733) (#10766)
The clickable div is positioned under the account avatar and covers
all empty space below it to the end of the status.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.