Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default to single column UI #10847

Merged
merged 1 commit into from May 30, 2019

Conversation

Projects
None yet
4 participants
@Gargron
Copy link
Member

commented May 26, 2019

Keeps current setting for people who have been active within the month preceding the database migration, if they were relying on the default value.

@ykzts

This comment has been minimized.

Copy link
Collaborator

commented May 27, 2019

I think existing users will be puzzled by change. I think it is better to change only the default for new users.

@marek-lach

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

I think existing users will be puzzled by change. I think it is better to change only the default for new users.

Agreed. This is why I think that the UI switch between single/advanced should also be in the Getting Started section, so that it's easily and quickly accessible and switch between for users.

@StarryAster

This comment has been minimized.

Copy link

commented May 29, 2019

A request:
Just like we admins can change the default theme for new users, could we also be able to choose if we want the single or multi column layout as default, instead of just changing the default for everybody who updates their instance?

This can really help those who have themes that are heavily customized, tutorials that rely on the multi-column layout, or other things to be able to update those accordingly before choosing single-column as default, while individual users can still enjoy the single-column layout if they prefer it.

Change default to single column UI
Keep current setting for users who were active within the last month

@Gargron Gargron force-pushed the fix-change-layout-default branch from 68f3294 to f5cade7 May 30, 2019

@Gargron

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

Updated PR to keep current setting for people active within the last month.

@ykzts

ykzts approved these changes May 30, 2019

@Gargron Gargron merged commit 738ad97 into master May 30, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@Gargron Gargron deleted the fix-change-layout-default branch May 30, 2019

JamesABDL added a commit to ABDL-Link/mastodon that referenced this pull request May 31, 2019

Change default to single column UI (tootsuite#10847)
Keep current setting for users who were active within the last month
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.