Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Edit profile" menu item name to match page title #10993

Open
wants to merge 1 commit into
base: master
from

Conversation

@mayaeh
Copy link
Collaborator

commented Jun 8, 2019

This PR matches the "Edit Profile" menu item with the page title.

This change will confuse translators once.
However, I believe that this change will make it easier to translate "appearance" by #10977 and #10988.

before:
スクリーンショット_2019-06-08_19_42_00

after:
スクリーンショット_2019-06-08_19_43_24

@Gargron

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

Maybe "profile appearance"? I'm not sure why just "appearance" is not okay

@mayaeh

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 8, 2019

The page title for settings/profile is "Edit profile".
But its menu item name was "Appearance".
I think that it is better to unify the page title and the menu item name.

Should I change them to "Profile appearance"?

@Cassolotl

This comment has been minimized.

Copy link

commented Jun 9, 2019

Page titles and menu titles being different is definitely confusing and makes it harder to find what you're looking for!

@koyuawsmbrtn

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

I would rather say

Profile
|_ Edit

Shorter and cleaner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.