Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor controllers for statuses, accounts, and more #11249

Merged
merged 1 commit into from Jul 8, 2019

Conversation

Projects
None yet
3 participants
@Gargron
Copy link
Member

commented Jul 7, 2019

  • Remove mark_cacheable! as useless abstraction
  • Use Active Model Serializers caching for ActivityPub JSON instead of custom solution
  • Add AccountOwnedConcern to unify logic for account-owned controllers
  • Replace repeated checks for public/unlisted visibility with distributable?
  • Bug fix: Some controllers did not return 404 for accounts that have not yet been approved
  • Bug fix: Remove link to Atom feed from account link header
  • Bug fix: Make sure lock is displayed for limited visibility statuses

@Gargron Gargron added the refactoring label Jul 7, 2019

@Gargron Gargron force-pushed the refactor-statuses-controller branch from 7a34a31 to 242be5e Jul 7, 2019

@Gargron Gargron force-pushed the refactor-statuses-controller branch from 242be5e to 8804048 Jul 7, 2019

@ykzts

ykzts approved these changes Jul 8, 2019

@Gargron Gargron merged commit 63c7fe8 into master Jul 8, 2019

2 checks passed

build-and-test Workflow: build-and-test
Details
codeclimate 5 fixed issues
Details
@Hanage999

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

This commit prevents toots created in my server (mastodon.crazynewworld.net) from federating. BTs federate without problem. Would you take a look into this?

zunda added a commit to zunda/mastodon that referenced this pull request Jul 9, 2019

ponapalt added a commit to ponapalt/mastodon that referenced this pull request Jul 9, 2019

@ykzts ykzts deleted the refactor-statuses-controller branch Jul 9, 2019

ponapalt added a commit to ponapalt/mastodon that referenced this pull request Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.