Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the retry limit in error of web push notification #11292

Merged

Conversation

@highemerly
Copy link
Contributor

commented Jul 12, 2019

In the error handling of Web::PushNotificationWorker, when status 40x is returned by
notification destination server, the job will not be retried. However, in case of status 50x, the web push job will be retries at 25 times by sidekiq. However, if destination server is heavy loaded, Web::PushNotificationWorker will retry it many times. Because the job is located at default queue, other important jobs may be delayed.

To avoid this, the maximum number of retry should be reduced. In my opinion, because the user who use the web push features requires real-time capability, the repeated retries of web push are not important. Improving the response of other jobs which is located at default queue may be prioritized than the "late" coming notification.

highemerly
Change the retry limit in error of web push notification
- Change the maximum count of retry for web push notification (Default -> 5).
   - In case of high load of subscribe server, the retries will be repeated many times.
   - Because the retries occupy the default queue, maximum retry count should be reduced.

@Gargron Gargron merged commit 4023027 into tootsuite:master Jul 12, 2019

2 checks passed

build-and-test Workflow: build-and-test
Details
codeclimate All good!
Details
ThibG added a commit to ThibG/mastodon that referenced this pull request Jul 14, 2019
Change the retry limit in error of web push notification (tootsuite#1…
…1292)

- Change the maximum count of retry for web push notification (Default -> 5).
   - In case of high load of subscribe server, the retries will be repeated many times.
   - Because the retries occupy the default queue, maximum retry count should be reduced.
ThibG added a commit to ThibG/mastodon that referenced this pull request Jul 14, 2019
Change the retry limit in error of web push notification (tootsuite#1…
…1292)

- Change the maximum count of retry for web push notification (Default -> 5).
   - In case of high load of subscribe server, the retries will be repeated many times.
   - Because the retries occupy the default queue, maximum retry count should be reduced.
Gargron added a commit that referenced this pull request Aug 9, 2019
Change the retry limit in error of web push notification (#11292)
- Change the maximum count of retry for web push notification (Default -> 5).
   - In case of high load of subscribe server, the retries will be repeated many times.
   - Because the retries occupy the default queue, maximum retry count should be reduced.
highemerly added a commit to highemerly/mastodon that referenced this pull request Aug 11, 2019
Change the retry limit in error of web push notification (tootsuite#1…
…1292)

- Change the maximum count of retry for web push notification (Default -> 5).
   - In case of high load of subscribe server, the retries will be repeated many times.
   - Because the retries occupy the default queue, maximum retry count should be reduced.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.