Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to disable the anti-spam #11296

Merged
merged 4 commits into from Jul 17, 2019

Conversation

@ThibG
Copy link
Collaborator

commented Jul 14, 2019

No description provided.

@ykzts
ykzts approved these changes Jul 14, 2019
@Gargron

This comment has been minimized.

Copy link
Member

commented Jul 14, 2019

I would prefer if the feature was perfected in such a way that hard-disabling it would not be necessary. Although as I understand it this action is pre-emptive as nobody has complained about too many false positives yet. But either way: This method makes disabling it inaccessible to masto.host (and similar) users.

@ThibG

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 14, 2019

Good point, going to change that to an admin panel setting.

@ThibG ThibG force-pushed the ThibG:fixes/disable-antispam branch from 9942c6d to 3523e6f Jul 14, 2019
@ThibG ThibG changed the title Add environment variable to disable the anti-spam Add setting to disable the anti-spam Jul 14, 2019
@ThibG

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 16, 2019

(It has been changed)

@@ -390,6 +391,9 @@ en:
activity_api_enabled:
desc_html: Counts of locally posted statuses, active users, and new registrations in weekly buckets
title: Publish aggregate statistics about user activity
antispam_enabled:
desc_html: Mastodon can auto-silence and auto-report accoutns based on measures such as detecting accounts who send repeated unsolicited messages. There may be false positives.

This comment has been minimized.

Copy link
@Gargron

Gargron Jul 16, 2019

Member

Typo in accounts

@@ -30,6 +30,7 @@ def index
@trending_hashtags = TrendingTags.get(7)
@profile_directory = Setting.profile_directory
@timeline_preview = Setting.timeline_preview
@antispam_enabled = Setting.antispam_enabled

This comment has been minimized.

Copy link
@Gargron

Gargron Jul 16, 2019

Member

If the Ruby class is called "spam_check" would it not be more consistent to name it "spam_check_enabled"? That being said it probably doesn't matter.

ThibG added 2 commits Jul 16, 2019
@ThibG ThibG force-pushed the ThibG:fixes/disable-antispam branch from 7ebc1ea to dbcfede Jul 17, 2019
@Gargron Gargron merged commit 7e2b6da into tootsuite:master Jul 17, 2019
2 checks passed
2 checks passed
build-and-test Workflow: build-and-test
Details
codeclimate All good!
Details
hiyuki2578 added a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
* Add environment variable to disable the anti-spam

* Move antispam setting to admin settings

* Fix typo

* antispam → spam_check
hiyuki2578 added a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
* Add environment variable to disable the anti-spam

* Move antispam setting to admin settings

* Fix typo

* antispam → spam_check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.