Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let bundler fetch http_parser.rb submodules #11444

Merged

Conversation

@petabyteboy
Copy link
Contributor

petabyteboy commented Jul 29, 2019

Motavation for this change:

The http_parser.rb gem uses git submodules and fetches them during the build. In situations where the dependencies for mastodon are fetched upfront, and a network connection is intentionally unavailable during the build, this will make the http_parser.rb gem build fail.
This is the case when packaging Mastodon with the Nix package manager.
Adding the submodules attribute makes bundler fetch the submodules upfront instead of them being fetched during the build process.

@petabyteboy

This comment has been minimized.

Copy link
Contributor Author

petabyteboy commented Jul 29, 2019

I think the build failure is not related to my changes.

@petabyteboy petabyteboy force-pushed the petabyteboy:feature/http_parser_submodules branch Jul 29, 2019
@Gargron

This comment has been minimized.

Copy link
Member

Gargron commented Jul 29, 2019

No, it is related:

The git source https://github.com/tmm1/http_parser.rb is not yet checked out. Please run `bundle install` before trying to start your application
@petabyteboy

This comment has been minimized.

Copy link
Contributor Author

petabyteboy commented Jul 29, 2019

It was failing with a different, unrelated error first (fuubar 2.4.0 could not be fetched). Now I rebased on master and it gives this different error. I will look into it later.

Gemfile.lock Outdated Show resolved Hide resolved
@petabyteboy petabyteboy force-pushed the petabyteboy:feature/http_parser_submodules branch to 7739851 Jul 29, 2019
@petabyteboy

This comment has been minimized.

Copy link
Contributor Author

petabyteboy commented Jul 29, 2019

The build failure was caused by the whitespace error @Shleeble found, now the build passes.

@Gargron Gargron merged commit 658277b into tootsuite:master Jul 29, 2019
2 checks passed
2 checks passed
build-and-test Workflow: build-and-test
Details
codeclimate All good!
Details
@petabyteboy petabyteboy mentioned this pull request Aug 26, 2019
11 of 20 tasks complete
hiyuki2578 added a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
katsusuke added a commit to katsusuke/mastodon that referenced this pull request Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.