Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve keyboard navigation in privacy dropdown #11492

Merged
merged 3 commits into from Aug 6, 2019

Conversation

@ThibG
Copy link
Collaborator

commented Aug 5, 2019

No description provided.

@ThibG

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 5, 2019

Hm, the focus isn't given back to the element that had it before the click, but to the icon button… I should probably fix that, but it will be a bit more involved

EDIT: fixed

@ThibG ThibG force-pushed the ThibG:fixes/privacy-dropdown-keyboard branch from 069b99b to bdac259 Aug 5, 2019
@ThibG ThibG force-pushed the ThibG:fixes/privacy-dropdown-keyboard branch from bdac259 to 5cb1122 Aug 5, 2019
@Gargron
Gargron approved these changes Aug 5, 2019
@Gargron Gargron merged commit 27a0d02 into tootsuite:master Aug 6, 2019
2 checks passed
2 checks passed
build-and-test Workflow: build-and-test
Details
codeclimate All good!
Details
Gargron added a commit that referenced this pull request Aug 9, 2019
* Trap tab in privacy dropdown

* Give focus back to last focused element when privacy dropdown menu closes

* Actually give back focus to the element that had it before clicking the dropdown
hiyuki2578 added a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
* Trap tab in privacy dropdown

* Give focus back to last focused element when privacy dropdown menu closes

* Actually give back focus to the element that had it before clicking the dropdown
hiyuki2578 added a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
* Trap tab in privacy dropdown

* Give focus back to last focused element when privacy dropdown menu closes

* Actually give back focus to the element that had it before clicking the dropdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.