Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audio player #11644

Merged
merged 1 commit into from Aug 23, 2019
Merged

Add audio player #11644

merged 1 commit into from Aug 23, 2019

Conversation

@Gargron
Copy link
Member

Gargron commented Aug 23, 2019

image

Generating a waveform requires loading the audio file in the browser. On the server side, generating the necessary data requires a program that is not in the Ubuntu sources by default and requires adding a custom launchpad. For this reason, for players that are rendered in timelines, we do not attempt to render a waveform, instead using a placeholder. Once "play" is clicked, the audio file loads and the real waveform is rendered. On detailed status pages, we load the file right away.

@Gargron Gargron added the ui label Aug 23, 2019
@Gargron Gargron force-pushed the feature-audio-player branch to cfc33c7 Aug 23, 2019
@ykzts
ykzts approved these changes Aug 23, 2019
@Gargron Gargron merged commit 4190e31 into master Aug 23, 2019
2 checks passed
2 checks passed
build-and-test Workflow: build-and-test
Details
codeclimate All good!
Details
@ykzts ykzts deleted the feature-audio-player branch Sep 5, 2019
hiyuki2578 added a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
katsusuke added a commit to katsusuke/mastodon that referenced this pull request Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.