Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use prebuilt node.js on Docker image #11768

Merged
merged 1 commit into from Sep 7, 2019

Conversation

@ykzts
Copy link
Collaborator

commented Sep 6, 2019

Uses too much CPU resources and memory when building Node.js from source code. This may cause the Docker image build to fail in an environment with insufficient resources.

Since Node.js has an official prebuilt binary, change it to use it.

@Shleeble

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

works for me.. Hopefully we migrate to flodgatt sooner than later and we can drop the nodejs.

@Gargron
Gargron approved these changes Sep 7, 2019

@Gargron Gargron merged commit d7ed697 into master Sep 7, 2019

2 checks passed

build-and-test Workflow: build-and-test
Details
codeclimate All good!
Details

@Gargron Gargron deleted the prebuilt-nodejs branch Sep 7, 2019

rtucker added a commit to vulpineclub/mastodon that referenced this pull request Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.