Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change spam check to apply to local accounts and add a threshold #11806

Merged
merged 1 commit into from Sep 18, 2019

Conversation

@Gargron
Copy link
Member

Gargron commented Sep 11, 2019

Instead of detecting spam on first duplicate message, add a threshold of 5 such messages to reduce false positives, since the check will now affect local accounts as well.

Instead of detecting spam on first duplicate message, add a
threshold of 5 such messages to reduce false positives
@ykzts
ykzts approved these changes Sep 12, 2019
Copy link
Collaborator

ThibG left a comment

Seems good (and actually better to catch bots opening accounts on legitimate Mastodon instances) overall, although I'm still worried about false positives given that the automatic action is quite drastic.

I'll run that on my instance for a while to get a sense of it, although I'm a single-user instance, so…

@Gargron Gargron merged commit 4f6af87 into master Sep 18, 2019
2 checks passed
2 checks passed
build-and-test Workflow: build-and-test
Details
codeclimate All good!
Details
@Gargron Gargron deleted the feature-spam-threshold branch Sep 18, 2019
hiyuki2578 added a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
…tsuite#11806)

Instead of detecting spam on first duplicate message, add a
threshold of 5 such messages to reduce false positives
katsusuke added a commit to katsusuke/mastodon that referenced this pull request Nov 26, 2019
…tsuite#11806)

Instead of detecting spam on first duplicate message, add a
threshold of 5 such messages to reduce false positives
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.