Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing locale file for ga and add rake task to check for it #11813

Merged
merged 3 commits into from Sep 12, 2019

Conversation

@Gargron
Copy link
Member

commented Sep 12, 2019

No description provided.

@Gargron Gargron added the bug label Sep 12, 2019
lib/tasks/repo.rake Outdated Show resolved Hide resolved
Co-Authored-By: Yamagishi Kazutoshi <ykzts@desire.sh>
@Gargron

This comment has been minimized.

Copy link
Member Author

commented Sep 12, 2019

I'm not sure why the new rake command is failing in CircleCI 😕

@ykzts

This comment has been minimized.

Copy link
Collaborator

commented Sep 12, 2019

I think you need to add - *install_system_dependencies to steps of check-i18n.

@Gargron

This comment has been minimized.

Copy link
Member Author

commented Sep 12, 2019

Oh, I wasn't aware it wasn't in the same environment as the other tests.

@ykzts
ykzts approved these changes Sep 12, 2019
@Gargron Gargron merged commit 9361981 into master Sep 12, 2019
2 checks passed
2 checks passed
build-and-test Workflow: build-and-test
Details
codeclimate All good!
Details
hiyuki2578 added a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
…tsuite#11813)

* Add missing locale file for ga and add rake task to check for it

* Update lib/tasks/repo.rake

Co-Authored-By: Yamagishi Kazutoshi <ykzts@desire.sh>

* Fix check-i18n build
hiyuki2578 added a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
…tsuite#11813)

* Add missing locale file for ga and add rake task to check for it

* Update lib/tasks/repo.rake

Co-Authored-By: Yamagishi Kazutoshi <ykzts@desire.sh>

* Fix check-i18n build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.