Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quotes in `LDAP_SEARCH_FILTER` example #12019

Merged
merged 1 commit into from Oct 1, 2019

Conversation

@madmath03
Copy link
Contributor

commented Sep 30, 2019

馃敡 Remove quotes in LDAP search filter

Keeping the double quotes in the .env.production would generate an invalid search filter exception.

@Gargron

This comment has been minimized.

Copy link
Member

commented Sep 30, 2019

Does it try to print Bash variables because of the double quotes?

@Gargron
Gargron approved these changes Oct 1, 2019
@Gargron Gargron changed the title Remove quotes in LDAP search filter Remove quotes in `LDAP_SEARCH_FILTER` example Oct 1, 2019
@Gargron Gargron merged commit b85fb6b into tootsuite:master Oct 1, 2019
2 checks passed
2 checks passed
build-and-test Workflow: build-and-test
Details
codeclimate All good!
Details
@madmath03

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2019

@Gargron The exception message was not very explicit, just saying that the search filter syntax was invalid, but I do believe the quotes were printed (docker does not interpret quotes in environment variables).

Thanks for merging this 馃槈

@madmath03 madmath03 deleted the Monogramm:fix/ldap_search_filter branch Oct 1, 2019
hiyuki2578 added a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
hiyuki2578 added a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.