Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `lang` attribute from individual statuses #12124

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@Gargron
Copy link
Member

Gargron commented Oct 9, 2019

Fix #10930

@ykzts
ykzts approved these changes Oct 9, 2019
@Gargron Gargron merged commit 538db85 into master Oct 9, 2019
2 checks passed
2 checks passed
build-and-test Workflow: build-and-test
Details
codeclimate All good!
Details
@Gargron Gargron deleted the fix-remove-lang branch Oct 9, 2019
@marrus-sh

This comment has been minimized.

Copy link
Contributor

marrus-sh commented Oct 10, 2019

I understand why this is necessary for CJK rendering, but it may also confound screenreaders, to the detriment of bilingual users which depend on them. (Screenreaders depend on the lang tag in order to know… what language to speak the text in.) It might be a good idea to add a user setting to re­‑enable this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.