Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix poll options not being selectable via keyboard #12538

Merged
merged 6 commits into from Dec 3, 2019

Conversation

@ThibG
Copy link
Collaborator

ThibG commented Dec 2, 2019

Fixes #12384

Also allow switching from single-option to multiple-option poll with keyboard and add a tooltip explaining that.

Changes the styling of hovered/focused/active checkboxes/radios as following:
Peek 02-12-2019 18-56

@ThibG ThibG force-pushed the ThibG:features/keyboard-poll-navigation branch from 369f4af to 01d288b Dec 2, 2019
@ThibG ThibG marked this pull request as ready for review Dec 2, 2019
@Gargron
Gargron approved these changes Dec 2, 2019
@ThibG

This comment has been minimized.

Copy link
Collaborator Author

ThibG commented Dec 2, 2019

Fixed some coding style issues, but I'll keep the .bind if there's no good reason for doing otherwise: this seems far simpler this way

@ThibG ThibG force-pushed the ThibG:features/keyboard-poll-navigation branch from 32d42a7 to 2e0f1a5 Dec 2, 2019
@ThibG

This comment has been minimized.

Copy link
Collaborator Author

ThibG commented Dec 2, 2019

Nevermind, updated it to avoid that, since it can have negative performance implications.

@Gargron
Gargron approved these changes Dec 3, 2019
@Gargron Gargron merged commit c05ed8a into tootsuite:master Dec 3, 2019
2 checks passed
2 checks passed
build-and-test Workflow: build-and-test
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.