Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Node v12 in Dockerfile #12703

Merged
merged 1 commit into from Dec 30, 2019
Merged

Upgrade Node v12 in Dockerfile #12703

merged 1 commit into from Dec 30, 2019

Conversation

@Shleeble
Copy link
Contributor

Shleeble commented Dec 29, 2019

This should be safe to merge anytime.

@Gargron

This comment has been minimized.

Copy link
Member

Gargron commented Dec 29, 2019

The PR title is wrong though, it’s v12, not v10

@ThibG ThibG changed the title Upgrade Node v10 in Dockerfile Upgrade Node v12 in Dockerfile Dec 29, 2019
@Shleeble

This comment has been minimized.

Copy link
Contributor Author

Shleeble commented Dec 30, 2019

Sorry about that. Just a typo, the PR is correct/tested.

@Gargron Gargron changed the title Upgrade Node v12 in Dockerfile Upgrade Node v10 in Dockerfile Dec 30, 2019
@Gargron Gargron changed the title Upgrade Node v10 in Dockerfile Upgrade Node v12 in Dockerfile Dec 30, 2019
@Gargron Gargron merged commit e7d3495 into tootsuite:master Dec 30, 2019
2 checks passed
2 checks passed
build-and-test Workflow: build-and-test
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.